Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Decibel #17

Closed
matjolic opened this issue Apr 18, 2016 · 5 comments
Closed

Add support for Decibel #17

matjolic opened this issue Apr 18, 2016 · 5 comments

Comments

@matjolic
Copy link

Would be very much appreciated :)
http://sbooth.org/Decibel/

@hoke-t
Copy link
Contributor

hoke-t commented Apr 19, 2016

Implemented here: https://github.com/hoke-t/BackgroundMusic/tree/Decibel

Will submit pull request once #27 is accepted (or denied)

@kyleneideck
Copy link
Owner

Thanks, @hoke-t. I haven't tested https://github.com/hoke-t/BackgroundMusic/tree/Decibel yet, but I just read through it and it looks good to me. Just two minor things:

  • When you moved the new files to BGMApp/BGMApp/Music Players you forgot to git rm the copies in BGMApp/BGMApp.
  • Would it be better to link to https://sbooth.org/Decibel/ instead of http://sbooth.org/Decibel/ in the README? (If so, we should do the same for the link to VOX.)

@DotTheI
Copy link

DotTheI commented May 11, 2016

Second this request

@hoke-t
Copy link
Contributor

hoke-t commented May 12, 2016

Working on it now.

@hoke-t
Copy link
Contributor

hoke-t commented May 14, 2016

Sorry the PR failed check, will fix it when I get a chance and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants