Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-pause settings isn't persisted #43

Open
choco opened this issue Apr 23, 2016 · 3 comments
Open

Auto-pause settings isn't persisted #43

choco opened this issue Apr 23, 2016 · 3 comments

Comments

@choco
Copy link

choco commented Apr 23, 2016

I personally use only Spotify, not iTunes, and everytime I have to go select Spotify from the menu.

@kyleneideck
Copy link
Owner

Hmm... I'm not sure what would be causing that. Is it happening when you restart Background Music.app, or just when you restart your computer?

The music player you chose is a property on the driver. If the driver gets restarted, usually because of a system restart, that setting gets lost (I haven't gotten around to persisting driver properties yet), but it shouldn't be lost when you restart the app. I just tried closing and reopening the app a few times and Spotify stayed chosen for me.

If you're getting this when you restart the app, it might be that the driver is crashing when you close the app. Do you get anything in your system log about it? The log messages would come from the coreaudiod process.

@choco
Copy link
Author

choco commented Apr 23, 2016

Ops, I'm sorry I didn't add that it only resets when restarting the system, as you correctly pointed out. It does preserve the setting if I'm just restarting the app.

@kyleneideck
Copy link
Owner

kyleneideck commented Apr 24, 2016

No worries. It's still useful to have Github issues for things that are also in TODO.md (or in TODOs in the code) so we can track them, get an idea of which ones people care about, etc.

Persisting driver settings shouldn't take much effort. The Core Audio driver interface BGMDriver implements, AudioServerPlugin, has an API for it that seems pretty straightforward. I just always forget about this issue because I use iTunes and rarely restart my computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants