Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration #4

Open
BetterDotNetter opened this issue May 13, 2014 · 12 comments
Open

Collaboration #4

BetterDotNetter opened this issue May 13, 2014 · 12 comments

Comments

@BetterDotNetter
Copy link
Collaborator

Hey,

It looks like there are a couple of projects that are all very similar in scope. I want to open an issue to see if there is any interest in combining efforts.

https://github.com/alex-simonov/RedisAspNetProviders

https://github.com/welegan/RedisSessionProvider

@yesdocs
Copy link
Collaborator

yesdocs commented May 13, 2014

I'm interested. What's the next step?

@alex-simonov
Copy link
Collaborator

I'm in. What's next?

@billpratt
Copy link
Contributor

I'm game. I'm in the process of converting from using Booksleeve to StackExchange.Redis but we can break that out into tasks. Also, we need more unit tests.

@kylesonaty
Copy link
Owner

I'm interested too. What's next?

@BetterDotNetter
Copy link
Collaborator Author

Good to hear that everyone is interested.

First thing, in terms of hosting the project, how does everyone want to do it? Should there be a separate repo for each provider or should they be under one repo like this one? Also where should the repo be hosted?

@yesdocs
Copy link
Collaborator

yesdocs commented May 14, 2014

I think we should have a repo per provider, all with a similar naming convention. (I'm looking at the use case of picking and choosing what provider one would want to use) Thoughts on naming is appreciated.

@alex-simonov
Copy link
Collaborator

A repo for each provider approach doesn't look good because there will be around 10 classes. If you look at existing code you will see that there is not so much code. Single repo for all providers will be a better approach. It is possible to implement a WebEventProvider in separate project because it has additional dependencies. So my suggestion is to have a single repo with two projects. And then we will publish two nuget packages: one for WebEventProvider and one for others.
And choosing a necessary provider is already implemented by ASP.NET and web.config.

-----Исходное сообщение-----
От: "George McKenzie" notifications@github.com
Отправлено: ‎14.‎05.‎2014 21:35
Кому: "kylesonaty/AspNetRedisProviders" AspNetRedisProviders@noreply.github.com
Копия: "Alexander Simonov" simonov.a.p@gmail.com
Тема: Re: [AspNetRedisProviders] Collaboration (#4)

I think we should have a repo per provider, all with a similar naming convention. (I'm looking at the use case of picking and choosing what provider one would want to use) Thoughts on naming is appreciated.

Reply to this email directly or view it on GitHub.

@billpratt
Copy link
Contributor

I agree with @alex-simonov

@yesdocs
Copy link
Collaborator

yesdocs commented May 14, 2014

I'm good with that, the dependencies were a primary concern.

@kylesonaty
Copy link
Owner

I also agree with @alex-simonov. As far as where we host it we can do it here. I added everyone that said they were interested as a collaborator to this repo.

@BetterDotNetter
Copy link
Collaborator Author

Would it make sense if everyone took responsibility for a specific provider? It's not meant to limit contributions to that person or anything but we can create tasks and people can volunteer. Thoughts?

@kylesonaty
Copy link
Owner

I am going to add some issues based on looking at the other projects and people can feel free to take them if they want. For example this repo doesn't have an output cache provider and some of the other session state providers use non locking sessions instead the standard way that asp.net locks session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants