New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional drum kits #10
base: master
Are you sure you want to change the base?
Conversation
Thanks @andlehma! I have some feedback on general approach here. First: are these samples royalty free and/or in the public domain? I want to avoid checking in anything copyrighted. Feedback on the approachThe lazy loading system should keep around all of the drum samples as buffers, perhaps organized in an object such as Ditto for loading states: we need to keep track of the loading state for each set of drum samples. Apart from that, I think the const drumMap = {
acoustic: { 0: '/path/to/file/', 1: ... },
808: { 0: '/path/to/file/', 1: ... },
}; This would simplify things a bit and it would allow // if we don't have buffers for this specific type and we're
// not already loading them, go ahead and load them.
if (!drumBuffers[type].length && !loadingDrums[type]) { ... } NitpicksThere's some formatting issues; I think you're using spaces while the repo is using tabs, and there are a few lines missing semicolons. |
Thanks for the great feedback @kylestetz I changed the loading approach in accordance with your feedback, so go ahead and take a look at it. As for the samples being royalty free, I'm not entirely sure. I downloaded them from sampleswap.org. At https://sampleswap.org/about, they don't seem too sure about the legality of the samples. They state:
Given that, I'd like to switch out the samples for something in much less of a grey-area. I looked around for some public domain drum samples, and found very little. Do you have any recommendations as to where I can find some good royalty free samples? |
Per issue #5
Lays out the framework to add tons of different drum kits. I only added one, but it would be pretty trivial to add more.