Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CI goodness #14

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Some CI goodness #14

merged 4 commits into from
Mar 11, 2024

Conversation

antoniovazquezblanco
Copy link
Contributor

Simple pipeline to at least compile the plugin in different Ghidra versions.

I did not know if you would enjoy automatic releases... For automated releases you can check if https://github.com/antoniovazquezblanco/GhidraFindcrypt/blob/main/.github/workflows/main.yml#L52 suits your needs.

@kylewlacy
Copy link
Owner

Thanks for this! I hadn't noticed the action to install Ghidra before, looks great!

I have a couple of tweaks I'd want to make before merging (mostly down to my particular taste for CI workflows), so I'll likely make a few tweaks on a separate branch and merge that way. Life's been kinda busy lately (which is also why I hadn't commented until now), so it might be a while before I get this in

@antoniovazquezblanco
Copy link
Contributor Author

Thanks for the feedback. I would like to see the changes to learn something back :)

@kylewlacy kylewlacy merged commit 9681afa into kylewlacy:main Mar 11, 2024
6 checks passed
@kylewlacy
Copy link
Owner

Alright, finally sat down and looked at this today, thanks again for the PR! I ended up making one small tweak before merging, but after reading through the docs, I think I want to revert it (specifically, I removed the on: pull_request event, I forgot that there's some difference with how that works with forks so I think it makes sense to add it back)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants