Add support for mapper 10 (MMC4) #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewlacy
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks for the PR! Sorry it took me so long to get around to reviewing it, but everything here looks great! Honestly I didn't test it (beyond making sure the build works) because I couldn't find a ROM on hand from what I have... but it sounds like you tested it more thoroughly than I would have anyway 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the MMC4 mapper.
A rare one, featured in only three games (source). I've tested all three and it worked fine. I suggest you test all of them as well, since they're so few.