Add automatic hashtag parsing from note-like posts #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edit/delete links on the venues screen didn't have the proper namespaces attached, so I added them
Adding a hashtag (#whatever) to a note-like article will replace it with a link and add the parsed tag to the post's tags automatically.
|
|
||
|
|
||
| def parse_hashtags(s): | ||
| # TODO: do this better |
There was a problem hiding this comment.
maybe pull out bs4_sub() into a top level function and use it here too?
|
This is great, I've been meaning to do something like it for a very long time. And thanks a lot for the test cases! |
|
I'll add test cases for URLs and large strings now |
This looks wayy more manageable than my old string splicer
|
Problem: twitter doesn't like it. #hashtag gets converted to /tag/<hashtag> in syndication |
Otherwise they'll be replaced in syndication by /tags/hashtag
kylewm
added a commit
that referenced
this pull request
Jun 4, 2015
Add automatic hashtag parsing from note-like posts
|
thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the function
util.parse_hashtagswhich accepts a string, looks for any hashtags in it (a pound sign followed by at least two alphanumunderscoric characters), and returns a tuple of the string with the hashtags linking to "tags/<hashtag>" and a list of the tags parsed out. The parsed tags are automatically added to the post's tag list when saved (admin.py line 281).Added because it's an easy and twitter-like way to add tags to a post.