Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secure resolver proposal #476

Merged

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Nov 19, 2019

Description

Changes proposed in this pull request:

  • update proposal with new names and new directive

Related issue(s)

See #419

@dbadura
Copy link
Contributor Author

dbadura commented Nov 20, 2019

Probably we can use the directive on field, but we need to update gqlgen to version 0.9.1

@crabtree
Copy link
Contributor

Probably we can use the directive on field, but we need to update gqlgen to version 0.9.1

As far as I know, we are now on 0.9.3

Copy link
Contributor

@crabtree crabtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just small comment.

@dbadura dbadura merged commit 302431e into kyma-incubator:master Nov 22, 2019
@dbadura dbadura deleted the update-secure-resolver-proposal branch November 22, 2019 13:36
DimitarPetrov pushed a commit to DimitarPetrov/compass that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants