Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade go mod #1391

Merged
merged 5 commits into from Sep 1, 2023
Merged

upgrade go mod #1391

merged 5 commits into from Sep 1, 2023

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Aug 29, 2023

No description provided.

@ruanxin ruanxin requested a review from a team as a code owner August 29, 2023 19:09
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 29, 2023
@ruanxin
Copy link
Contributor Author

ruanxin commented Aug 30, 2023

/test pull-main-reconciler-integration-k3d

@ruanxin
Copy link
Contributor Author

ruanxin commented Aug 30, 2023

/test pull-main-cli-kyma-release-upgrade-k3d

ruanxin
ruanxin commented Aug 30, 2023
View reviewed changes
go.mod

replace github.com/imdario/mergo => github.com/imdario/mergo v0.3.5

replace github.com/docker/docker => github.com/docker/docker v23.0.7-0.20230730020554-801e90549aac+incompatible
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reviewer:
have to use this verison atm testcontainers/testcontainers-go#1359 (comment)

@kyma-bot
Copy link

kyma-bot commented Aug 30, 2023 •
edited

@ruanxin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-reconciler-publish-pr-cli c28f59f link true /test pre-main-reconciler-publish-pr-cli

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lindnerby lindnerby removed their assignment Aug 30, 2023
@ruanxin
Copy link
Contributor Author

ruanxin commented Aug 31, 2023 •
edited

pre-main-reconciler-publish-pr-cli failing is expected, because the dependencies upgraded in this PR is not compatible with current CLI, after this get merged, in CLI need to upgrade reconciler dependencies.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 31, 2023
@ruanxin
Copy link
Contributor Author

ruanxin commented Sep 1, 2023

/test pre-main-reconciler-publish-pr-cli

@kyma-bot kyma-bot merged commit 00dd6cd into kyma-incubator:main Sep 1, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP approved these changes

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch jeremyharisch is a code owner automatically assigned from kyma-incubator/jellyfish

Assignees

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP

Labels
lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ruanxin @kyma-bot @Tomasz-Smelcerz-SAP @lindnerby