Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Switch to core.gardener.cloud/v1beta1 API group #34

Closed
ialidzhikov opened this issue Dec 25, 2019 · 5 comments · Fixed by kyma-project/hydroform#80
Closed

Switch to core.gardener.cloud/v1beta1 API group #34

ialidzhikov opened this issue Dec 25, 2019 · 5 comments · Fixed by kyma-project/hydroform#80
Assignees
@rakesh-garimella
Labels
area/cli Related to all activities around CLI

Comments

@ialidzhikov
Copy link
Contributor

Description
Currently kyma-incubator/terraform-provider-gardener consumes the old and deprecated garden.sapcloud.io/v1beta1 API group which soon will reach end of life.
Since gardener/gardener@0.30.0 there is core.gardener.cloud/v1alpha1 and since gardener/gardener@v0.33.0 there is core.gardener.cloud/v1beta1.
@a-thaler
Copy link
Collaborator

a-thaler commented Jan 8, 2020

Thanks for the feedback, we will update to the new versions

@a-thaler a-thaler added this to the Backlog_Huskies milestone Jan 8, 2020
@neo-liang-sap neo-liang-sap self-assigned this Jan 13, 2020
@neo-liang-sap
Copy link
Contributor

i will take look at this issue :)

neo-liang-sap added a commit to neo-liang-sap/terraform-provider-gardener that referenced this issue Jan 14, 2020
@neo-liang-sap
Switch to core.gardener.cloud/v1beta1 API group
549da1a 
kyma-incubator#34
@neo-liang-sap neo-liang-sap mentioned this issue Jan 14, 2020
Merged
@neo-liang-sap
Copy link
Contributor

Hi @a-thaler / @ialidzhikov :

Not sure i'm understanding correctly and heading correct approach, this issue means refactor reference in terraform-provider-gardener from garden.sapcloud.io/v1beta1 to core.gardener.cloud/v1beta1

Is there anything else i need to take care of?

If i'm right i have prepared the PR, correct me if i was wrong...
#38

Thanks!

-Neo

neo-liang-sap added a commit that referenced this issue Jan 15, 2020
@neo-liang-sap
Switch to core.gardener.cloud/v1beta1 API group (#38)
677de95 
#34
@neo-liang-sap
Copy link
Contributor

PR in this issue is reverted by #42

some more info - https://listserv.sap.corp/pipermail/kubernetes-users/2019-October/000692.html

@a-thaler a-thaler added the area/cli Related to all activities around CLI label Jan 24, 2020
@a-thaler a-thaler modified the milestones: Backlog_Huskies, Sprint_Huskies_18 Jan 24, 2020
@rakesh-garimella rakesh-garimella mentioned this issue Jan 30, 2020
Merged
@a-thaler a-thaler modified the milestones: Sprint_Huskies_18, Sprint_Huskies_19 Feb 4, 2020
This was referenced Feb 4, 2020
Merged
Merged
This was referenced Feb 7, 2020
Merged
Merged
Merged
Merged
@sayanh sayanh mentioned this issue Feb 10, 2020
Closed
@rakesh-garimella rakesh-garimella mentioned this issue Feb 12, 2020
Merged
@a-thaler a-thaler removed this from the Sprint_Huskies_19 milestone Feb 14, 2020
@a-thaler a-thaler added this to the Sprint_Huskies_20 milestone Feb 14, 2020
This was referenced Feb 18, 2020
Merged
Merged
Merged
Closed
@a-thaler
Copy link
Collaborator

a-thaler commented Mar 2, 2020

All three providers (AWS, GCP, Azure) are supported now as before

@a-thaler a-thaler closed this as completed Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakesh-garimella rakesh-garimella

Labels
area/cli Related to all activities around CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update hydroform for latest gardener api rakesh-garimella/hydroform
4 participants
@a-thaler @ialidzhikov @rakesh-garimella @neo-liang-sap