GCP Service Broker in the main index.yaml #120
Conversation
piotrmiskiewicz
requested review from
adamwalach,
aszecowka,
jasiu001,
mszostok,
PK85 and
polskikiel
as code owners
addons/index.yaml
Outdated
| google-cloud-platform-service-broker: | ||
| - name: google-cloud-platform-service-broker | ||
| description: "Google Cloud Platform Service Broker" |
There was a problem hiding this comment.
Could we ask @PK85 and change it to GCP Service Broker? I will be more consistent because we have already AWS Service Broker and not Amazon Web Services Service Broker
The upstream chart is also called just gcp-service-broker: https://github.com/GoogleCloudPlatform/gcp-service-broker/tree/master/deployments/helm/gcp-service-broker
If PK will agree then we should change also the directory name to make it consistent
There was a problem hiding this comment.
changed to gcp-service-broker
| @@ -20,7 +20,7 @@ replicaCount: 1 | |||
| brokerDocBasePath: https://raw.githubusercontent.com/GoogleCloudPlatform/gcp-service-broker/754f612578a163362821553d2b2122ba9d122c43/docs/classes | |||
| image: | |||
| repository: gcr.io/gcp-service-broker/gcp-service-broker@sha256 | |||
| tag: 2162aaa06bb7b1fdfb17d6f7f8148e1b66f08f588f8476223852b93ae38ce1db | |||
| tag: 76ab8f091a314b657036d353dffa4f5e7de491e355a307149ece325a81f0d96c | |||
There was a problem hiding this comment.
update also comment above
| @@ -0,0 +1,54 @@ | |||
| apiVersion: batch/v1 | |||
There was a problem hiding this comment.
can we also move the docs.yaml into that folder and make that as a best practice?
thanks to that only inside the docu dir we will have our customization, everything else should be the same as the upstream chart
piotrmiskiewicz
requested review from
bszwarc,
kazydek,
klaudiagrz,
majakurcius,
mmitoraj and
tomekpapiernik
as code owners
piotrmiskiewicz
force-pushed
the
bump-gcp-broker
branch
from
51fa75c
to
c536d7a
Compare
piotrmiskiewicz
changed the title
piotrmiskiewicz
added
the
kind/feature
Description
Changes proposed in this pull request:
Related issue(s)
Related: kyma-project/kyma#5395