Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Fix a variable name in the command #136

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Conversation

klaudiagrz
Copy link
Contributor

@klaudiagrz klaudiagrz commented Jul 14, 2020

Description

The GCP Broker documentation includes the line:

kubectl create secret generic gcp-broker-data --from-file=sa-key={filename} --from-literal=project-name={gcp-project} --namespace {namespace}

To spare possible confusion for users, it might be cunning to replace gcp-project with gcp-project-id, as it is the project ID (and not project name) that is required.

Changes proposed in this pull request:

  • Fix a variable name in the command from {gcp-project} to {GCP_PROJECT_ID}

Related issue(s)

@klaudiagrz klaudiagrz added kind/bug Categorizes issue or PR as related to a bug. area/documentation Issues or PRs related to documentation labels Jul 14, 2020
@CLAassistant
Copy link

CLAassistant commented Jul 14, 2020

CLA assistant check
All committers have signed the CLA.

Copy link

@kazydek kazydek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@klaudiagrz klaudiagrz merged commit b567f55 into kyma-project:master Jul 14, 2020
@klaudiagrz klaudiagrz deleted the 1234 branch July 14, 2020 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/documentation Issues or PRs related to documentation kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants