Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioner: POC for creating dynamic kubeconfig secrets in the Cluster Inventory #3017

Closed
wants to merge 14 commits into from

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Aug 23, 2023

Description

This is a POC for introducing Cluster Inventory, and creating secrets with dynamic Kubeconfig. DO NOT MERGE.

Changes proposed in this pull request:

  • Cluster Inventory scaffolding
  • Cluster Inventory creates secrets with dynamic kubeconfig
  • Cluster Inventory rotates dynamic kubeconfigs

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/documentation Issues or PRs related to documentation labels Aug 23, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akgalwas akgalwas changed the title Scaffolding for Cluster Inventory operator Provisioner: POC for creating dynamic kubeconfig secrets in the Cluster Inventory Aug 23, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 8, 2023

@akgalwas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-new-kyma-environment-broker 6ac974d link true /test pre-new-kyma-environment-broker

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


type State string

const StateKubeconfigError State = "Kubeconfig creation error"
Copy link
Contributor

@m00g3n m00g3n Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change it to fit the convention e.g:

ErrKubeconfigCreationFailed = "kubeconfig creation failed"


//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
// +kubebuilder:resource:path=clusters,scope=Cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we align all annotations?

type ClusterSpec struct {
Core Core `json:"core,omitempty"`
AdminKubeconfig AdminKubeconfig `json:"adminKubeconfig,omitempty"`
Status ClusterStatus `json:"status,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the purpose of this property?
It may be a confusing to have multiple statuses: L58, L27

@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot kyma-bot closed this Nov 18, 2023
@kyma-bot
Copy link
Contributor

@kyma-bot: Closed this PR.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants