Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete L2/L3 operator bindings from provisioner #3438

Merged
merged 2 commits into from
May 21, 2024

Conversation

ebensom
Copy link
Member

@ebensom ebensom commented May 17, 2024

Description

Changes proposed in this pull request:

The L2 and L3 operator bindings were for a legacy (OIDC based) approach to authorize SAP operator access to SKRs, but are not needed any more.

After this PR is merged, I plan to raise another PR to remove related code from kcp chart.

Related issue(s)

https://github.tools.sap/kyma/backlog/issues/5553

@ebensom ebensom requested a review from a team as a code owner May 17, 2024 06:30
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2024
@mvshao mvshao assigned koala7659 and unassigned akgalwas May 20, 2024
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

@ebensom ebensom requested a review from koala7659 May 21, 2024 07:01
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@kyma-bot kyma-bot merged commit bc0d834 into kyma-project:main May 21, 2024
5 of 6 checks passed
@ebensom ebensom deleted the remove-l2l3operator-bindings branch May 21, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants