Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

POC HB: Client auth when creating Helm release #102

Closed
PK85 opened this issue Jun 8, 2020 · 1 comment · Fixed by #104
Closed

POC HB: Client auth when creating Helm release #102

PK85 opened this issue Jun 8, 2020 · 1 comment · Fixed by #104
Assignees
Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@PK85
Copy link
Collaborator

PK85 commented Jun 8, 2020

Description

POC with working solution where user with proper rights can provision redis addon.

Reasons

This will be Input for impl issue: #67

AC
Demo for:

  • usecase 1: user with proper rights can provision redis addon
  • usecase 2: user with lack of resource permission cannot successfuly provision redis addon
  • usecase 3: check technical accounts to provision redis addon
    • service account (groups?)
@PK85 PK85 added this to the 1.14 milestone Jun 8, 2020
@PK85 PK85 added area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature. labels Jun 8, 2020
@mszostok mszostok linked a pull request Jun 15, 2020 that will close this issue
@mszostok mszostok modified the milestones: 1.14, 1.15 Jun 22, 2020
@polskikiel
Copy link
Contributor

polskikiel commented Jun 28, 2020

I checked the ServiceInstance status when the user doesn't have proper permissions to provision some service (with async provisioning).

The SI status looks like:
image

The above error status contains many errors.Wrap() and its message could be simplified. With the errors.Cause() we should be able to indicate if an error is NotForbidden type using errors.IsForbidden().

UP:

I created a PR to improve the error message, with my changes it looks like it:
image

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants