-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of the converter for provider specific config for GCP #248
Implementation of the converter for provider specific config for GCP #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For aws
and azure
the go file is named provider_specific_config.go
while for gcp
and ccee
it's providerspecificconfig.go
. Could you align those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + verified that it works
@@ -14,7 +14,7 @@ func GetInfrastructureConfig(workerCIDR string, zones []string) ([]byte, error) | |||
return json.Marshal(NewInfrastructureConfig(workerCIDR, zones)) | |||
} | |||
|
|||
func GetControlPlaneConfig() ([]byte, error) { | |||
func GetControlPlaneConfig(_ []string) ([]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this parameter be omitted?
Description
Changes proposed in this pull request:
Related issue(s)
#206