Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass configuration parameters to the Infrastructure Manager #42

Merged
merged 15 commits into from
Sep 22, 2023
Merged

Pass configuration parameters to the Infrastructure Manager #42

merged 15 commits into from
Sep 22, 2023

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Sep 19, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Added makefile target for creating secret with gardener credentials
  • Added application parameter containing path to Gardener kubeconfig file
  • Added kustomize patch for deployment

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2023
@akgalwas akgalwas marked this pull request as ready for review September 20, 2023 04:07
@akgalwas akgalwas requested a review from a team as a code owner September 20, 2023 04:07
@akgalwas akgalwas requested a review from a team as a code owner September 20, 2023 04:31
Disper
Disper reviewed Sep 20, 2023
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
@akgalwas akgalwas changed the title [WIP] Pass configuration parameters to the Infrastructure Manager Pass configuration parameters to the Infrastructure Manager Sep 20, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@akgalwas akgalwas mentioned this pull request Sep 20, 2023
Closed
6 tasks
Disper
Disper reviewed Sep 20, 2023
View reviewed changes
Makefile Show resolved Hide resolved
Disper
Disper reviewed Sep 21, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Disper
Disper requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@Disper Disper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is a change request. Others are rather general feedback that I don't have a strong opinion about.

Disper
Disper previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Disper Disper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2023
grego952
grego952 reviewed Sep 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Disper @grego952
Update README.md
54da923 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 22, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2023
@kyma-bot kyma-bot merged commit 0d22ae0 into kyma-project:main Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@Disper Disper Disper left review comments

Assignees

@Disper Disper

@m00g3n m00g3n

@grego952 grego952

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akgalwas @kyma-bot @Disper @grego952 @m00g3n