Implement kubeconfig rotation #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/L
6 tasks
Disper
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
kyma-bot
added
size/XL
akgalwas
changed the title
Disper
commented
Oct 25, 2023
| } | ||
| var clusterToUpdate imv1.GardenerCluster | ||
|
|
||
| err := controller.Client.Get(ctx, key, &clusterToUpdate) |
There was a problem hiding this comment.
just a comment for myself - this prevents 409 error
Disper
commented
Oct 25, 2023
| now := time.Now() | ||
| alreadyValidFor := now.Sub(lastSyncTime) | ||
|
|
||
| return alreadyValidFor.Minutes() >= rotationPeriodRatio*rotationPeriod.Minutes() |
There was a problem hiding this comment.
would it be possible to remove this rotationPeriodRatio parameter?
There was a problem hiding this comment.
without that, @akgalwas had a test case where instead after 36 minutes, rotation happened after ~72 minutes and if I recall correctly, for 12 minutes the kubeconfig was invalid.
Disper
commented
Oct 25, 2023
| return false | ||
| } | ||
|
|
||
| readyState := newGardenerCluster.Status.State == imv1.ReadyState |
There was a problem hiding this comment.
Happened to fail for @akgalwas locally
|
What should be taken into account during review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#10