Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the event-type cleanup logic #11007

Merged
merged 4 commits into from Apr 1, 2021
Merged

Update the event-type cleanup logic #11007

merged 4 commits into from Apr 1, 2021

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Mar 29, 2021 •
edited

Description

Update the event-type cleanup logic to allow events with more than two segments.

Related issue(s)
#10997

@marcobebway marcobebway requested a review from a user March 29, 2021 15:02
@marcobebway marcobebway self-assigned this Mar 29, 2021
@marcobebway marcobebway added the area/eventing Issues or PRs related to eventing label Mar 29, 2021
@marcobebway marcobebway linked an issue Mar 29, 2021 that may be closed by this pull request
Events with type with more that 2 segments fail to get published #10997
Closed
@marcobebway marcobebway mentioned this pull request Mar 29, 2021
Merged
@marcobebway marcobebway force-pushed the update-event-type-cleanup branch 3 times, most recently from 7787b00 to 5b30ba9 Compare March 30, 2021 19:05
@marcobebway marcobebway requested a review from themue March 31, 2021 15:15
k15r
k15r approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@k15r k15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcobebway marcobebway merged commit 81e3637 into kyma-project:master Apr 1, 2021
marcobebway added a commit to marcobebway/kyma that referenced this pull request Apr 1, 2021
@marcobebway
Update the event-type cleanup logic (kyma-project#11007)
e446fcb
@marcobebway marcobebway deleted the update-event-type-cleanup branch April 1, 2021 11:52
marcobebway added a commit to marcobebway/kyma that referenced this pull request Apr 1, 2021
@marcobebway
Update the event-type cleanup logic (kyma-project#11007)
35493ed
k15r pushed a commit that referenced this pull request Apr 1, 2021
@marcobebway
Update the event-type cleanup logic (#11007) (#11034)
3547bd3 
* Update the event-type cleanup logic (#11007)

* Update the Eventing publishers and controllers images (#11008)

* Update the Eventing docs (#11036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

@themue themue themue approved these changes

@anishj0shi anishj0shi Awaiting requested review from anishj0shi

@berkanercan berkanercan Awaiting requested review from berkanercan

@lilitgh lilitgh Awaiting requested review from lilitgh

@montaro montaro Awaiting requested review from montaro

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@sayanh sayanh Awaiting requested review from sayanh

Assignees

@marcobebway marcobebway

Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events with type with more that 2 segments fail to get published
3 participants
@marcobebway @k15r @themue