Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nats queue subscriptions #11621

Merged
merged 23 commits into from Jul 21, 2021
Merged

Use Nats queue subscriptions #11621

merged 23 commits into from Jul 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2021

Description

Changes proposed in this pull request:

  • It contains the changes to eventing-controller for NATS queue subscriptions

TODO:

  • Test changing maxInFlight on a running subscription
  • A simple upgrade test since we have changes in the Subscription CRD?

Related issue(s)

Closes #11665

@ghost ghost added area/eventing Issues or PRs related to eventing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 2, 2021
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 2, 2021
@ghost ghost linked an issue Jul 2, 2021 that may be closed by this pull request
5 tasks
@ghost ghost changed the title POC: Nats queue subscriptions WIP - POC: Nats queue subscriptions Jul 2, 2021
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2021
@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 6b87111

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/60ed565e8e955d00089667a9

😎 Browse the preview: https://deploy-preview-11621--kyma-project-docs-preview.netlify.app

@ghost ghost mentioned this pull request Jul 2, 2021
5 tasks
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2021
@ghost ghost requested a review from a-thaler as a code owner July 15, 2021 14:57
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2021
@pxsalehi
Copy link
Contributor

/retest

3 similar comments
@ghost
Copy link
Author

ghost commented Jul 19, 2021

/retest

@ghost
Copy link
Author

ghost commented Jul 19, 2021

/retest

@ghost
Copy link
Author

ghost commented Jul 20, 2021

/retest

@ghost
Copy link
Author

ghost commented Jul 20, 2021

/test pre-kyma-components-eventing-controller

@ghost ghost changed the title WIP - POC: Nats queue subscriptions Nats queue subscriptions Jul 20, 2021
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021
@kyma-bot
Copy link
Contributor

@radufa: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost changed the title Nats queue subscriptions Use Nats queue subscriptions Jul 20, 2021
@ghost ghost removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@pxsalehi
Copy link
Contributor

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 21, 2021
@pxsalehi
Copy link
Contributor

/retest pre-kyma-components-eventing-controller

@kyma-bot

This comment has been minimized.

@pxsalehi
Copy link
Contributor

/test pre-kyma-components-eventing-controller

Copy link
Contributor

@pPrecel pPrecel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxsalehi
Copy link
Contributor

/test pre-main-kyma-gke-upgrade

@kyma-bot kyma-bot merged commit 794b8c3 into kyma-project:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
4 participants