Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Central Application Gateway and Central Connectivity Validator to kyma-system namespace #11631

Merged
merged 10 commits into from Jul 12, 2021
Merged

Move Central Application Gateway and Central Connectivity Validator to kyma-system namespace #11631

merged 10 commits into from Jul 12, 2021

Conversation

franpog859
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Move Central Application Gateway and Central Connectivity Validator to kyma-system namespace

Related issue(s)

See the issue here

@franpog859 franpog859 added kind/feature Categorizes issue or PR as related to a new feature. area/application-connector Issues or PRs related to application connectivity labels Jul 5, 2021
@franpog859 franpog859 self-assigned this Jul 5, 2021
@kyma-bot
Copy link
Contributor

kyma-bot commented Jul 5, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2021
@franpog859
Copy link
Contributor Author

/test all

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2021
@franpog859
Copy link
Contributor Author

/test all

@franpog859
Copy link
Contributor Author

/test all

@franpog859
Copy link
Contributor Author

/test all

@franpog859
Copy link
Contributor Author

/test all

@netlify
Copy link

netlify bot commented Jul 6, 2021 •
edited

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 0eabcb8

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/60e7ecd10de49c0007ce6e19

😎 Browse the preview: https://deploy-preview-11631--kyma-project-docs-preview.netlify.app

@franpog859
Copy link
Contributor Author

/test all

@franpog859
Copy link
Contributor Author

/test all

@franpog859
Copy link
Contributor Author

Feel free to test it by yourself! To do it you can for example:

  1. provision a cluster for example using Gardener
  2. checkout on my branch, go to the resources/application-connector/values.yaml file, and change the central_application_connectivity_validator.enabled value to true, so there will be Central Application Connectivity Validator used:
central_application_connectivity_validator:
  enabled: &centralApplicationConnectivityValidatorEnabled true #change it from false to true
  1. go to the fast-integration test directory with cd tests/fast-integration and install Kyma with Central Application Gateway using ./kyma.js install --skip-components kiali,tracing --with-central-application-gateway
  2. run the test with the Central Application Gateway flow using env WITH_CENTRAL_APPLICATION_GATEWAY=true mocha test/2-commerce-mock.js -b

@franpog859 franpog859 marked this pull request as ready for review July 6, 2021 08:56
@franpog859 franpog859 mentioned this pull request Jul 6, 2021
Closed
2 tasks
Maladie
Maladie previously approved these changes Jul 8, 2021
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 8, 2021
mmitoraj
mmitoraj requested changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@mmitoraj mmitoraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment from me. Thanks!

components/central-application-gateway/README.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 8, 2021
@franpog859 @mmitoraj
Update components/central-application-gateway/README.md
82c3705 
Co-authored-by: Małgorzata Świeca <mitorajmalgorzata@gmail.com>
@franpog859
Copy link
Contributor Author

/test all

mmitoraj
mmitoraj previously approved these changes Jul 8, 2021
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 8, 2021
Maladie
Maladie previously approved these changes Jul 8, 2021
View reviewed changes
@franpog859
Copy link
Contributor Author

/test pre-main-kyma-gke-upgrade

@franpog859 franpog859 dismissed stale reviews from Maladie and mmitoraj via 0eabcb8 July 9, 2021 06:29
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 9, 2021
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 9, 2021
@Maladie
Copy link
Contributor

Maladie commented Jul 12, 2021

/retest

@kyma-bot kyma-bot merged commit a797a5b into kyma-project:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crabtree crabtree crabtree approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

@ksputo ksputo ksputo approved these changes

@Maladie Maladie Maladie approved these changes

@adamwalach adamwalach Awaiting requested review from adamwalach

@akgalwas akgalwas Awaiting requested review from akgalwas

@janmedrek janmedrek Awaiting requested review from janmedrek

@jasiu001 jasiu001 Awaiting requested review from jasiu001

@koala7659 koala7659 Awaiting requested review from koala7659

@lilitgh lilitgh Awaiting requested review from lilitgh

@pbochynski pbochynski Awaiting requested review from pbochynski

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz

@PK85 PK85 Awaiting requested review from PK85

@rafalpotempa rafalpotempa Awaiting requested review from rafalpotempa

@ralikio ralikio Awaiting requested review from ralikio

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@kazydek kazydek Awaiting requested review from kazydek

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@majakurcius majakurcius Awaiting requested review from majakurcius

@NHingerl NHingerl Awaiting requested review from NHingerl

Assignees

@crabtree crabtree

@mmitoraj mmitoraj

@ksputo ksputo

@Maladie Maladie

@franpog859 franpog859

Labels
area/application-connector Issues or PRs related to application connectivity kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@franpog859 @kyma-bot @Maladie @crabtree @mmitoraj @ksputo