Add Central Connectivity Validator fast integration tests #11676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalpotempa
added
area/application-connector
rafalpotempa
requested review from
adamwalach,
crabtree and
pbochynski
as code owners
kyma-bot
added
the
size/S
kyma-bot
added
size/M
kyma-bot
added
size/L
|
✔️ 🥰 Documentation preview ready! 🥰 🔨 Explore the source changes: af93699 🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61027c745a1c6e0007e3df23 😎 Browse the preview: https://deploy-preview-11676--kyma-project-docs-preview.netlify.app |
franpog859
reviewed
Jul 22, 2021
rafalpotempa
force-pushed
the
central-connectivity-validator
branch
from
c2096a6
to
6203ac2
Compare
|
/test pre-main-kyma-integration-k3s-compass-dev |
1 similar comment
|
/test pre-main-kyma-integration-k3s-compass-dev |
franpog859
previously approved these changes
Aug 2, 2021
franpog859
previously approved these changes
Aug 2, 2021
pbochynski
reviewed
Aug 3, 2021
| @@ -44,15 +42,15 @@ describe("Kyma with Compass test", async function() { | |||
| return; | |||
| } | |||
|
|
|||
| await installer.installKyma({withCompass: true, skipComponents, withCentralApplicationGateway}); | |||
| await installer.installKyma({skipComponents: componentsToSkip, withCompass: true, withCentralAppConnectivity: withCentralAppConnectivity}); | |||
There was a problem hiding this comment.
You can leave shorthand property names notation
There was a problem hiding this comment.
Now it's like this:
await installer.installKyma({withCompass: true, withCentralAppConnectivity: withCentralAppConnectivity, componentsToSkip});
pbochynski
reviewed
Aug 3, 2021
| @@ -42,7 +42,7 @@ describe("Kyma with Compass test", async function() { | |||
| return; | |||
| } | |||
|
|
|||
| await installer.installKyma({skipComponents: componentsToSkip, withCompass: true, withCentralAppConnectivity: withCentralAppConnectivity}); | |||
| await installer.installKyma({withCompass: true, withCentralAppConnectivity: withCentralAppConnectivity, componentsToSkip}); | |||
There was a problem hiding this comment.
The shorthand for object initialization works when key and value match (you can skip value). In case of skipComponents it is not a case. Rename componentsToSkip variable or keep the long syntax.
pbochynski
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#11654