Add liveness and readiness probes to prometheus operator #11735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhalash
added
kind/feature
skhalash
requested review from
a-thaler,
chrkl,
clebs,
jeremyharisch,
lilitgh,
rakesh-garimella and
suleymanakbas91
as code owners
kyma-bot
added
the
size/L
|
/retest |
skhalash
changed the title
skhalash
added
the
do-not-merge/hold
jeremyharisch
approved these changes
Jul 23, 2021
jeremyharisch
removed
the
do-not-merge/hold
|
@skhalash: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new way of monitoring Kyma runtime availability requires readiness probes to be configured for all workloads (deployments, stateful sets, daemon sets). Prometheus operator does not expose a health check endpoint, so as a workaround, the metrics endpoint will be used for this purpose.
The bitnami/IBM fork of the upstream chart is doing the same: https://github.com/bitnami/charts/blame/master/bitnami/kube-prometheus/values.yaml#L225
Changes proposed in this pull request:
Related issue(s)