Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fast integration tests with central app gateway failing #12116

Merged
merged 2 commits into from Sep 20, 2021
Merged

Fix fast integration tests with central app gateway failing #12116

merged 2 commits into from Sep 20, 2021

Conversation

franpog859
Copy link
Contributor

@franpog859 franpog859 commented Sep 16, 2021 •
edited

This reverts commit c61f026.

Description

Changes proposed in this pull request:

  • Fix fast integration tests with central app gateway failing

Related issue(s)
See the issue here

@franpog859 franpog859 added kind/bug Categorizes issue or PR as related to a bug. area/application-connector Issues or PRs related to application connectivity labels Sep 16, 2021
@franpog859 franpog859 self-assigned this Sep 16, 2021
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2021
@franpog859
Copy link
Contributor Author

Here are logs from the affected jobs acquired with pjtester:

@franpog859 franpog859 mentioned this pull request Sep 17, 2021
Merged
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 17, 2021
@rafalpotempa rafalpotempa added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2021
a-thaler
a-thaler reviewed Sep 20, 2021
View reviewed changes
tests/fast-integration/Makefile
@@ -30,3 +30,13 @@ ci-post-upgrade:
npm install
npm run upgrade-test-tests
npm run upgrade-test-cleanup

.PHONY: ci-application-connectivity-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there is a "-2" everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these are pipelines related to Application Connectivity 2.0 components

@franpog859 franpog859 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@franpog859
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-central-app-connectivity-compass

@kyma-bot
Copy link
Contributor

@franpog859: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pre-kyma-tests-integration-api-gateway
  • /test pre-kyma-components-apiserver-proxy
  • /test pre-kyma-tests-integration-apiserver-proxy
  • /test pre-kyma-components-application-broker
  • /test pre-kyma-components-application-connectivity-certs-setup-job
  • /test pre-kyma-components-application-connectivity-validator
  • /test pre-kyma-tests-application-connector-tests
  • /test pre-kyma-components-application-gateway
  • /test pre-kyma-tests-application-gateway-legacy-tests
  • /test pre-kyma-tests-application-gateway-tests
  • /test pre-kyma-components-application-operator
  • /test pre-kyma-tests-application-operator-tests
  • /test pre-kyma-components-application-registry
  • /test pre-kyma-tests-application-registry-tests
  • /test pre-main-kyma-common
  • /test pre-kyma-components-compass-runtime-agent
  • /test pre-kyma-tests-compass-runtime-agent
  • /test pre-kyma-components-connection-token-handler
  • /test pre-kyma-tests-connection-token-handler-tests
  • /test pre-kyma-components-connector-service
  • /test pre-kyma-tests-connector-service-tests
  • /test pre-kyma-components-console-backend-service
  • /test pre-kyma-components-dex-static-user-configurer
  • /test pre-kyma-tests-integration-dex
  • /test pre-kyma-components-event-publisher-proxy
  • /test pre-kyma-components-eventing-controller
  • /test pre-main-kyma-tools-failery
  • /test pre-kyma-components-function-controller
  • /test pre-kyma-tests-function-controller
  • /test pre-kyma-components-function-runtimes
  • /test kyma-metadata-schema-governance
  • /test pre-main-kyma-governance
  • /test pre-kyma-components-iam-kubeconfig-service
  • /test pre-kyma-components-istio-installer
  • /test pre-kyma-artifacts
  • /test pre-main-kyma-gke-external-registry
  • /test pre-main-kyma-integration-k3d
  • /test pre-main-serverless-integration-k3s
  • /test pre-main-serverless-integration-alpha-k3s
  • /test pre-main-cluster-users-integration-k3d
  • /test pre-kyma-components-kyma-operator
  • /test pre-kyma-tests-integration-logging
  • /test pre-kyma-components-nats-operator
  • /test pre-kyma-components-permission-controller
  • /test pre-main-kyma-protecode-guard
  • /test pre-kyma-tests-rafter
  • /test pre-kyma-components-service-binding-usage-controller
  • /test pre-kyma-tests-service-catalog
  • /test pre-kyma-components-telemetry-operator
  • /test pre-kyma-components-uaa-activator
  • /test pre-kyma-tests-end-to-end-upgrade
  • /test pre-kyma-components-xip-patch

The following commands are available to trigger optional jobs:

  • /test pre-kyma-components-busola-migrator
  • /test pre-kyma-components-central-application-connectivity-validator
  • /test pre-kyma-components-central-application-gateway
  • /test pre-kyma-tools-event-subscriber
  • /test pre-main-check-users-map
  • /test pre-main-kyma-gardener-azure-fast-integration
  • /test pre-main-kyma-gardener-azure-alpha-eval
  • /test pre-main-kyma-gardener-azure-alpha-prod
  • /test pre-main-kyma-integration-k3d-compass-dev

Use /test all to run the following jobs that were automatically triggered:

  • pre-kyma-artifacts
  • pre-main-check-users-map
  • pre-main-kyma-integration-k3d
  • pre-main-kyma-integration-k3d-compass-dev

In response to this:

/test pre-main-kyma-integration-k3d-central-app-connectivity-compass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@franpog859
Copy link
Contributor Author

/test all

@halamix2
Copy link
Member

/retest

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 20, 2021
@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 0ec3c53

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61486131729508000765e968

😎 Browse the preview: https://deploy-preview-12116--kyma-project-docs-preview.netlify.app

@halamix2
Copy link
Member

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 20, 2021
@franpog859 franpog859 merged commit 16f834c into kyma-project:main Sep 20, 2021
@franpog859 franpog859 mentioned this pull request Sep 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-thaler a-thaler a-thaler left review comments

@rafalpotempa rafalpotempa rafalpotempa approved these changes

@lindnerby lindnerby lindnerby approved these changes

@adamwalach adamwalach Awaiting requested review from adamwalach

@crabtree crabtree Awaiting requested review from crabtree

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@pbochynski pbochynski Awaiting requested review from pbochynski

@rakesh-garimella rakesh-garimella Awaiting requested review from rakesh-garimella

@shorim shorim Awaiting requested review from shorim

@skhalash skhalash Awaiting requested review from skhalash

@voigt voigt Awaiting requested review from voigt

@wozniakjan wozniakjan Awaiting requested review from wozniakjan

Assignees

@halamix2 halamix2

@franpog859 franpog859

@rafalpotempa rafalpotempa

@lindnerby lindnerby

Labels
area/application-connector Issues or PRs related to application connectivity kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@franpog859 @kyma-bot @halamix2 @a-thaler @rafalpotempa @lindnerby