Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read eventTypePrefix from ConfigMap #12189

Merged

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Sep 24, 2021

Description

Read eventTypePrefix from ConfigMap.

Related issue(s)

#10579

@marcobebway marcobebway requested a review from a user September 24, 2021 08:18
@marcobebway marcobebway self-assigned this Sep 24, 2021
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 24, 2021
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2021
@marcobebway marcobebway force-pushed the 10579-configmap-event-type-prefix branch from a0ca399 to 1ce4163 Compare September 28, 2021 09:10
@kyma-project kyma-project deleted a comment from kyma-bot Sep 28, 2021
@kyma-project kyma-project deleted a comment from kyma-bot Sep 28, 2021
@kyma-project kyma-project deleted a comment from netlify bot Sep 28, 2021
@marcobebway marcobebway force-pushed the 10579-configmap-event-type-prefix branch from 1ce4163 to 928dad0 Compare September 28, 2021 09:29
@kyma-project kyma-project deleted a comment from kyma-bot Sep 28, 2021
@marcobebway marcobebway force-pushed the 10579-configmap-event-type-prefix branch from 928dad0 to f9845e2 Compare September 28, 2021 09:38
@kyma-project kyma-project deleted a comment from kyma-bot Sep 28, 2021
@kyma-project kyma-project deleted a comment from kyma-bot Sep 28, 2021
@marcobebway
Copy link
Contributor Author

/retest

@kyma-project kyma-project deleted a comment from kyma-bot Sep 28, 2021
@kyma-project kyma-project deleted a comment from kyma-bot Sep 28, 2021
@marcobebway marcobebway added the area/eventing Issues or PRs related to eventing label Sep 28, 2021
@marcobebway
Copy link
Contributor Author

/retest

1 similar comment
@marcobebway
Copy link
Contributor Author

/retest

@marcobebway
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2021
@marcobebway marcobebway force-pushed the 10579-configmap-event-type-prefix branch from 6d45232 to f81dec8 Compare September 28, 2021 14:41
@marcobebway
Copy link
Contributor Author

/retest

@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 29, 2021
@marcobebway
Copy link
Contributor Author

/retest

ghost
ghost previously approved these changes Sep 30, 2021
@marcobebway marcobebway force-pushed the 10579-configmap-event-type-prefix branch from e7d6bdd to f034f62 Compare October 13, 2021 12:12
@kyma-project kyma-project deleted a comment from kyma-bot Oct 13, 2021
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 13, 2021
@marcobebway
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2021
@kyma-bot kyma-bot merged commit 031426c into kyma-project:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
2 participants