Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed trailing spaces in fluent-bit config #12232

Merged
merged 1 commit into from Sep 30, 2021

Conversation

a-thaler
Copy link
Contributor

Description
trailing spaces in the fluent-bit config were letting the yaml multi-line block be stored differently in the k8s configmap (to keep the trailing spaces) leading to an unreadable config block.

Changes proposed in this pull request:

  • Removed the trailing spaces, now the config is beautiful to read at runtime in the configmap
  • ...
  • ...

Related issue(s)

@a-thaler a-thaler added the area/logging Issues or PRs related to the logging module (deprecated) label Sep 29, 2021
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2021
@shorim
Copy link
Contributor

shorim commented Sep 30, 2021

/test pre-main-kyma-integration-k3d-compass-dev

@shorim
Copy link
Contributor

shorim commented Sep 30, 2021

/test pre-main-kyma-integration-k3d-central-app-connectivity-compass

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 30, 2021
@kyma-bot kyma-bot merged commit d0968dc into kyma-project:main Sep 30, 2021
@kyma-bot
Copy link
Contributor

@a-thaler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gke-external-registry f04eb8b link unknown /test pre-main-kyma-gke-external-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-thaler a-thaler added this to the 2.0-m3 milestone Oct 1, 2021
@a-thaler a-thaler deleted the fluent-config branch October 26, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issues or PRs related to the logging module (deprecated) lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants