Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address linting issues #12283

Merged
merged 27 commits into from Oct 7, 2021
Merged

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Oct 5, 2021

Description

Changes proposed in this pull request:

  • rename constants
  • rename functions
  • rename variables
  • rename subscription-nats to subscription/nats and subscription to subscription/beb
  • reorder signatures to move ctx into first position

Related issue(s)

@k15r k15r requested a review from a user October 5, 2021 14:52
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 5, 2021
@k15r k15r added the area/eventing Issues or PRs related to eventing label Oct 5, 2021
@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 090acb1

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/615dbc70f459c700083ef4c0

😎 Browse the preview: https://deploy-preview-12283--kyma-project-docs-preview.netlify.app

@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2021
@k15r
Copy link
Contributor Author

k15r commented Oct 6, 2021

/retest

@k15r
Copy link
Contributor Author

k15r commented Oct 6, 2021

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 7, 2021
@k15r
Copy link
Contributor Author

k15r commented Oct 7, 2021

/retest

@kyma-bot kyma-bot merged commit 3a80477 into kyma-project:main Oct 7, 2021
@k15r k15r deleted the address-linting-issues branch February 3, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants