fix the eventingReady status change right after the backend switch #12312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
do-not-merge/work-in-progress
|
|
kyma-bot
added
the
size/M
…ting the publisherReady flag
kyma-bot
added
size/L
|
✔️ 🥰 Documentation preview ready! 🥰 🔨 Explore the source changes: 14337c1 🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61840c0393f808000825ccc2 😎 Browse the preview: https://deploy-preview-12312--kyma-project-docs-preview.netlify.app |
…correct-status-update-sequence
|
/test all |
k15r
reviewed
Oct 18, 2021
| @@ -1282,6 +1283,8 @@ func createSubscriptionObjectsAndWaitForReadiness(ctx context.Context, givenSubs | |||
| // countBEBRequests returns how many requests for a given subscription are sent for each HTTP method | |||
| func countBEBRequests(subscriptionName string) (countGet int, countPost int, countDelete int) { | |||
| countGet, countPost, countDelete = 0, 0, 0 | |||
| var mutex = &sync.Mutex{} | |||
There was a problem hiding this comment.
thats not how a mutex works. The idea is that all potential accessors of the mutexed resource, need to acquire the lock of the mutex. as only one can get this at a time the access to the resource is not access simultaneously
There was a problem hiding this comment.
I added a global RWMutex
k15r
reviewed
Oct 18, 2021
components/eventing-controller/reconciler/subscription/beb/reconciler_test.go
Outdated
Show resolved
Hide resolved
vpaskar
requested review from
adamwalach,
crabtree,
jeremyharisch,
lilitgh,
lindnerby,
marcobebway,
mfaizanse,
nachtmaar,
pbochynski and
pxsalehi
as code owners
…correct-status-update-sequence
vpaskar
removed request for
pbochynski,
wozniakjan,
voigt,
crabtree,
skhalash,
adamwalach,
shorim,
rakesh-garimella,
jeremyharisch and
lindnerby
mfaizanse
reviewed
Nov 8, 2021
components/eventing-controller/controllers/backend/reconciler_test.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/controllers/backend/reconciler_test.go
Outdated
Show resolved
Hide resolved
mfaizanse
approved these changes
Nov 10, 2021
vpaskar
removed
the
do-not-merge/hold
|
@VladislavPaskar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
friedrichwilken
pushed a commit
to friedrichwilken/kyma
that referenced
this pull request
Nov 15, 2021
…yma-project#12312) * fix the eventingReady status change right after the backend switch * add pod's generation in the unit tests; check for pod status when setting the publisherReady flag * fix imports and codestyle * lock the beb.requests during the iteration * use RWmutex instead of the normal one * revert the sleep * reduce amount of nested loops, some code adjustments * fix imports * remove mutex, add early return * fix condition, improve for loops * update mocked pod's status * remove comment * bump the image to solve the security issue
mfaizanse
pushed a commit
to mfaizanse/kyma
that referenced
this pull request
Nov 19, 2021
…yma-project#12312) * fix the eventingReady status change right after the backend switch * add pod's generation in the unit tests; check for pod status when setting the publisherReady flag * fix imports and codestyle * lock the beb.requests during the iteration * use RWmutex instead of the normal one * revert the sleep * reduce amount of nested loops, some code adjustments * fix imports * remove mutex, add early return * fix condition, improve for loops * update mocked pod's status * remove comment * bump the image to solve the security issue
mfaizanse
pushed a commit
to mfaizanse/kyma
that referenced
this pull request
Nov 19, 2021
…yma-project#12312) * fix the eventingReady status change right after the backend switch * add pod's generation in the unit tests; check for pod status when setting the publisherReady flag * fix imports and codestyle * lock the beb.requests during the iteration * use RWmutex instead of the normal one * revert the sleep * reduce amount of nested loops, some code adjustments * fix imports * remove mutex, add early return * fix condition, improve for loops * update mocked pod's status * remove comment * bump the image to solve the security issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)