Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Application Connectivity docs to Kyma 2.0, pt.2 #12465

Merged
merged 27 commits into from Nov 19, 2021

Conversation

majakurcius
Copy link
Contributor

@majakurcius majakurcius commented Oct 26, 2021

Description

Update the Application Connectivity 2.0 docs to Kyma 2.0

Changes proposed in this pull request:

  • Adjust the tutorials to the new Application Connectivity solution (central App Gateway and App Conn Validator)
  • Adjust the tutorials forming the main flow to use environment variables instead of re-typing the names for APP_NAME, CLUSTER_DOMAIN, CLIENT_CERTIFICATE_FILE_NAME, KEY_FILE_NAME, SERVICE_ID.

Related issue(s)
#11047

@majakurcius majakurcius added area/documentation Issues or PRs related to documentation area/application-connector Issues or PRs related to application connectivity do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 26, 2021
@majakurcius majakurcius self-assigned this Oct 26, 2021
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 26, 2021
@majakurcius majakurcius added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 26, 2021
@majakurcius majakurcius changed the title Adjust Application Connectivity docs to Kyma 2.0, pt.2 Adjust Application Connectivity docs to Kyma 2.0, pt.2 [WIP] Oct 26, 2021
@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 0e4601f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61968f994305210007447212

😎 Browse the preview: https://deploy-preview-12465--kyma-project-docs-preview.netlify.app

@klaudiagrz klaudiagrz self-assigned this Nov 16, 2021
@@ -83,18 +84,28 @@ A successful call returns the following response:
}
```

> **NOTE:** The response contains URLs to the Application Registry API and the Events Publisher API, however, it is not recommended to use them. You should call the `metadata` endpoint URL, which is provided in `api.infoUrl` property, to fetch correct URLs to the Application Registry API and to the Events Publisher API, and other configuration details.
> **NOTE:** The response contains URLs to the Application Registry API and the Events Publisher API, however, using them is not recommended. You should call the `metadata` endpoint URL, which is provided in the **api.infoUrl** property, to fetch correct URLs to the Application Registry API and to the Events Publisher API, and other configuration details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence feels a bit too long. Can we chunk it into two shorter ones?

@majakurcius majakurcius added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
Copy link
Contributor

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

klaudiagrz
klaudiagrz previously approved these changes Nov 18, 2021
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2021
klaudiagrz
klaudiagrz previously approved these changes Nov 18, 2021
Copy link
Contributor

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2021
… export as env var, fix typo in KEY file name
Comment on lines -154 to -162
## Call Application Registry and Event Publisher on local deployment

Since the local Kyma installation uses the self-signed certificate by default, skip TLS verification.

Call Application Registry with this command:

```bash
curl https://gateway.local.kyma.dev/{APP_NAME}/v1/metadata/services --cert {CLIENT_CERT_FILE_NAME}.crt --key {KEY_FILE_NAME}.key -k
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this part, 'cause we don't want to have commands for local deployment specifically, just mention to skip cert verification (we have such a note at the top of the document), and if we turn it into a general command working for both a local and remote cluster, it becomes the same as the command in the previous section.

openssl req -new -sha256 -out generated.csr -key generated.key -subj "/OU=OrgUnit/O=Organization/L=Waldorf/ST=Waldorf/C=DE/CN={APP_NAME}"
openssl base64 -in generated.csr
openssl req -new -sha256 -out $CSR_FILE_NAME.csr -key $KEY_FILE_NAME.key -subj "/OU=OrgUnit/O=Organization/L=Waldorf/ST=Waldorf/C=DE/CN=$APP_NAME"
openssl base64 -in $CSR_FILE_NAME.csr -A
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added -A here because it gets rid of the newlines in the printed CSR, which I otherwise have to remove manually.

Comment on lines +42 to 46
2. Export the ID of the registered service and the Namespace in which to create the Function that calls the service as environment variables:

```bash
export SERVICE_ID={YOUR_SERVICE_ID}
export NAMESPACE={YOUR_NAMESPACE}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added exporting the Namespace to an env var back here since I mistakenly removed it before.

@majakurcius majakurcius changed the title Adjust Application Connectivity docs to Kyma 2.0, pt.2 [WIP] Adjust Application Connectivity docs to Kyma 2.0, pt.2 Nov 18, 2021
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 19, 2021
@majakurcius majakurcius removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2021
@kyma-bot kyma-bot merged commit 0c37f5e into kyma-project:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity area/documentation Issues or PRs related to documentation lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants