clean event types #12488
Merged
clean event types #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichwilken
requested review from
k15r,
lilitgh,
marcobebway,
mfaizanse,
nachtmaar and
pxsalehi
as code owners
kyma-bot
added
the
size/L
|
/hold |
kyma-bot
added
the
do-not-merge/hold
mfaizanse
removed
the
do-not-merge/hold
k15r
reviewed
Nov 11, 2021
components/eventing-controller/api/v1alpha1/subscription_types.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/reconciler/subscription/nats/reconciler.go
Outdated
Show resolved
Hide resolved
k15r
reviewed
Nov 11, 2021
friedrichwilken
force-pushed
the
backendInfrastructures
branch
from
be0da5c
to
0e6e6b8
Compare
|
✔️ 🥰 Documentation preview ready! 🥰 🔨 Explore the source changes: 7b43176 🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61c990458be63a00074307f2 😎 Browse the preview: https://deploy-preview-12488--kyma-project-docs-preview.netlify.app |
marcobebway
reviewed
Nov 17, 2021
friedrichwilken
requested review from
adamwalach,
dariusztutaj,
m00g3n,
mjakobczyk and
pPrecel
as code owners
kyma-bot
added
size/L
|
/retest |
|
/test pre-main-kyma-integration-k3d-central-app-connectivity-compass |
|
/test-required |
|
/test pre-main-kyma-integration-k3d-compass-dev |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
friedrichwilken
force-pushed
the
backendInfrastructures
branch
from
2958fc2
to
7b43176
Compare
marcobebway
force-pushed
the
backendInfrastructures
branch
from
7b43176
to
a9ccd35
Compare
|
/lgtm |
marcobebway
approved these changes
Dec 27, 2021
mfaizanse
pushed a commit
to mfaizanse/kyma
that referenced
this pull request
Jan 20, 2022
* added backendInfrastructures to subscription types * reworked nats * add unit tests * Add more test * adding beb tests for clean event type implementation * adjustments after review * added backendInfrastructures to subscription types * reworked nats * add unit tests * Add more test * adding beb tests for clean event type implementation * adjustments after review * refactoring after proper testing * adding clean event types to nats * re-added missing code * bump image * copy-crds * fixed missing crds * make beb and nats resolve cleanEventTypes more similar * fixing more failing tests * add mutex to beb_mock * switch from Mutex to RWMutex * adjust to rebase * use RLock und Lock properly * rebase * refactor according to recent code review reset of values * fixing flaky tests * linting issues * Refine tests for BEB * Small refactoring and typo fixes Co-authored-by: Marco Bebway <marco.bebway@sap.com> Co-authored-by: Korbinian Stoemmer <292906+k15r@users.noreply.github.com>
kyma-bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
…cherry-picked from main) (#13122) * clean event types (#12488) * added backendInfrastructures to subscription types * reworked nats * add unit tests * Add more test * adding beb tests for clean event type implementation * adjustments after review * added backendInfrastructures to subscription types * reworked nats * add unit tests * Add more test * adding beb tests for clean event type implementation * adjustments after review * refactoring after proper testing * adding clean event types to nats * re-added missing code * bump image * copy-crds * fixed missing crds * make beb and nats resolve cleanEventTypes more similar * fixing more failing tests * add mutex to beb_mock * switch from Mutex to RWMutex * adjust to rebase * use RLock und Lock properly * rebase * refactor according to recent code review reset of values * fixing flaky tests * linting issues * Refine tests for BEB * Small refactoring and typo fixes Co-authored-by: Marco Bebway <marco.bebway@sap.com> Co-authored-by: Korbinian Stoemmer <292906+k15r@users.noreply.github.com> * Avoid the deletion of NATS-subscription at each reconciliation call (#13050) * updated nats handler to check for change in filters, maxInflight and sink * removed maxInflight change and fixed tests * switch to using sync.Map * addressed review comments * addressed review comments 2 * addressed review comments 3 * fixed failing tests Co-authored-by: Friedrich <58187735+FriedrichWilken@users.noreply.github.com> Co-authored-by: Marco Bebway <marco.bebway@sap.com> Co-authored-by: Korbinian Stoemmer <292906+k15r@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses this issue:
When creating backend infrastructures we take the
filters->eventType->value, clean it up and name the backend infrastructure by this name, while leaving theeventType->valueuntouched. This leads to confusion about the actual name of the backend infrastructure. To resolve this, the fieldSubscriptionStatus->CleanEventTypeswas added that contains the cleaned names.Alongside some minor refactoring happened.