Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added kyma disclaimer to istio svc & po #12506

Merged
merged 4 commits into from Nov 8, 2021
Merged

added kyma disclaimer to istio svc & po #12506

merged 4 commits into from Nov 8, 2021

Conversation

strekm
Copy link
Contributor

@strekm strekm commented Oct 29, 2021

Description

Changes proposed in this pull request:

  • added kyma disclaimer to istio svc & po

Related issue(s)

@strekm strekm added area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh labels Oct 29, 2021
@strekm strekm added this to the 2.0-m4 milestone Oct 29, 2021
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2021
@netlify
Copy link

netlify bot commented Oct 29, 2021 •
edited

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 77e5305

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/617c038ac7dee7000855c5ff

😎 Browse the preview: https://deploy-preview-12506--kyma-project-docs-preview.netlify.app

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2021
mjakobczyk
mjakobczyk approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@mjakobczyk mjakobczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 8, 2021

@mjakobczyk: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 8, 2021
@kyma-bot kyma-bot merged commit d93f396 into kyma-project:main Nov 8, 2021
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 8, 2021

@strekm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gke-external-registry 77e5305 link unknown /test pre-main-kyma-gke-external-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

friedrichwilken pushed a commit to friedrichwilken/kyma that referenced this pull request Nov 15, 2021
@strekm @cnvergence @friedrichwilken
added kyma disclaimer to istio svc & po (kyma-project#12506)
a0293d5 
* added kyma disclaimer to istio svc & po

* added kyma disclaimer to istio svc & po

* Fix annotations

* Move annotations from values and fix indent

Co-authored-by: Karol Szwaj <karol.szwaj@gmail.com>
@strekm strekm deleted the istio-annotations branch November 24, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjakobczyk mjakobczyk mjakobczyk approved these changes

@dariusztutaj dariusztutaj Awaiting requested review from dariusztutaj

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@werdes72 werdes72 Awaiting requested review from werdes72

Assignees

@mjakobczyk mjakobczyk

Labels
area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
2.0-m4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@strekm @kyma-bot @mjakobczyk @cnvergence