Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add managed-by label to apps and configmap to skr #12876

Merged
merged 4 commits into from Dec 20, 2021
Merged

Add managed-by label to apps and configmap to skr #12876

merged 4 commits into from Dec 20, 2021

Conversation

franpog859
Copy link
Contributor

@franpog859 franpog859 commented Dec 15, 2021 •
edited

Description

Changes proposed in this pull request:

  • Add applicationconnector.kyma-project.io/managed-by: compass-runtime-agent label to SKR apps and skr-configmap to the SKR in the kyma-system namespace

See kyma-project/busola#712

@franpog859 franpog859 added kind/feature Categorizes issue or PR as related to a new feature. area/application-connector Issues or PRs related to application connectivity labels Dec 15, 2021
@franpog859 franpog859 self-assigned this Dec 15, 2021
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 15, 2021
@franpog859
Copy link
Contributor Author

/test pre-kyma-components-compass-runtime-agent

@franpog859
Copy link
Contributor Author

/test all

koala7659
koala7659 approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 17, 2021
@franpog859
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-central-app-connectivity

@kyma-bot kyma-bot merged commit 2f523a8 into kyma-project:main Dec 20, 2021
franpog859 added a commit to franpog859/kyma that referenced this pull request Dec 20, 2021
@franpog859
Add managed-by label to apps and configmap to skr (kyma-project#12876)
ec7a2d7 
* Add managed-by label to apps and configmap to skr

* Bump CRA

* Remove not needed labels

* Use string instead of boolean
@franpog859 franpog859 mentioned this pull request Dec 20, 2021
Closed
franpog859 added a commit to franpog859/kyma that referenced this pull request Dec 21, 2021
@franpog859
Add managed-by label to apps and configmap to skr (kyma-project#12876)
ca14708 
* Add managed-by label to apps and configmap to skr

* Bump CRA

* Remove not needed labels

* Use string instead of boolean
@franpog859 franpog859 mentioned this pull request Dec 21, 2021
Merged
kyma-bot pushed a commit that referenced this pull request Dec 21, 2021
@franpog859
Cherry pick adding app labels by CRA (#12916)
7c9913f 
* Add managed-by label to apps and configmap to skr (#12876)

* Add managed-by label to apps and configmap to skr

* Bump CRA

* Remove not needed labels

* Use string instead of boolean

* Bump CRA (#12903)
@franpog859 franpog859 mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

@akgalwas akgalwas Awaiting requested review from akgalwas

@dbadura dbadura Awaiting requested review from dbadura

@janmedrek janmedrek Awaiting requested review from janmedrek

@Maladie Maladie Awaiting requested review from Maladie

@PK85 PK85 Awaiting requested review from PK85

@ralikio ralikio Awaiting requested review from ralikio

Assignees

@koala7659 koala7659

@franpog859 franpog859

Labels
area/application-connector Issues or PRs related to application connectivity kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franpog859 @koala7659 @kyma-bot