Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kube state metrics #13037

Merged
merged 32 commits into from Jan 20, 2022

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Jan 11, 2022

Description

Changes proposed in this pull request:

  • Updated kube-state-metrics to 2.3.0
  • Synced the chart changes with upstream
  • Removed the customization from _helper.tpl
  • kube-state-metrics cluster role can be toggled via values.yaml
  • Some major sync in deployment.yaml
  • Updated the grafana dashboards and alertrules which are affected by metric name changes
  • Fixed the test after metric renaming
  • Update grafana dashboard and alerting rules, since they depend on the new metrics
  • Allow kube_pod_labels since 2.1: kube_deployment_labels metric missing DEPLOYMENT_LABEL labels kubernetes/kube-state-metrics#1489

Metric renames:

  • kube_daemonset_updated_number_scheduled -> kube_daemonset_status_updated_number_scheduled
  • kube_hpa_* -> kube_horizontalpodautoscaler_*

Dropped metrics (as per https://github.com/kubernetes/kube-state-metrics/tree/release-1.9/docs#metrics-deprecation)

  • The following non-generic resource metrics for pods are removed. kube_pod_container_resource_requests and kube_pod_container_resource_limits are the replacements with resource labels representing the resource name and unit labels representing the resource unit.
    kube_pod_container_resource_requests_cpu_cores
    kube_pod_container_resource_limits_cpu_cores
    kube_pod_container_resource_requests_memory_bytes
    kube_pod_container_resource_limits_memory_bytes
  • The following non-generic resource metrics for nodes are removed. kube_node_status_capacity and kube_node_status_allocatable are the replacements with resource labels representing the resource name and unit labels representing the resource unit.
    kube_node_status_capacity_pods
    kube_node_status_capacity_cpu_cores
    kube_node_status_capacity_memory_bytes
    kube_node_status_allocatable_pods
    kube_node_status_allocatable_cpu_cores
    kube_node_status_allocatable_memory_bytes

Interesting changes:

Related issue(s)

#11567

- Kubestate metrics values.yaml and clusterrolebinding
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 11, 2022
@rakesh-garimella
Copy link
Contributor Author

/retest

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: fd40799

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61e9764746179a000859cdc9

😎 Browse the preview: https://deploy-preview-13037--kyma-project-docs-preview.netlify.app

@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 13, 2022
@chrkl
Copy link
Member

chrkl commented Jan 20, 2022

/retest

chrkl
chrkl previously approved these changes Jan 20, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 20, 2022
@skhalash
Copy link
Contributor

/retest

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 20, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 20, 2022
@skhalash
Copy link
Contributor

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Jan 20, 2022

@rakesh-garimella: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-telemetry-operator-test 2deb938 link true /test pre-telemetry-operator-test
pre-main-kyma-gardener-azure-alpha-prod fd40799 link false /test pre-main-kyma-gardener-azure-alpha-prod

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 7af2f61 into kyma-project:main Jan 20, 2022
@skhalash skhalash deleted the update-kube-state-metrcis branch January 20, 2022 16:45
@a-thaler a-thaler added this to the 2.1 milestone Jan 21, 2022
@a-thaler a-thaler added the area/monitoring Issues or PRs related to the monitoring module (deprecated) label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants