Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nats reconciler when subscription filters are modified #13126

Merged
merged 10 commits into from Jan 28, 2022
Merged

Improve nats reconciler when subscription filters are modified #13126

merged 10 commits into from Jan 28, 2022

Conversation

mfaizanse
Copy link
Member

@mfaizanse mfaizanse commented Jan 20, 2022 •
edited

Description

Related issue(s)

@mfaizanse mfaizanse added area/eventing Issues or PRs related to eventing do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 20, 2022
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2022
@mfaizanse mfaizanse linked an issue Jan 20, 2022 that may be closed by this pull request
Improve the NATs reconciler to not delete all NATS subscriptions if the subscription filters are modified #13108
Closed
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2022
@mfaizanse mfaizanse marked this pull request as ready for review January 21, 2022 08:05
@mfaizanse mfaizanse requested a review from a user January 21, 2022 08:05
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2022
@mfaizanse mfaizanse mentioned this pull request Jan 21, 2022
Merged
@mfaizanse
Copy link
Member Author

/test pre-main-kyma-skr-eventing

2 similar comments
@mfaizanse
Copy link
Member Author

/test pre-main-kyma-skr-eventing

@mfaizanse
Copy link
Member Author

/test pre-main-kyma-skr-eventing

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2022
@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 0929d5f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61f11b070feb5c000859fde1

😎 Browse the preview: https://deploy-preview-13126--kyma-project-docs-preview.netlify.app

k15r
k15r reviewed Jan 26, 2022
View reviewed changes
components/eventing-controller/pkg/handlers/nats_test.go

// TestNatsSubAfterSync_FilterRemoved tests the SyncSubscription method
// when a filter is removed from subscription
func TestNatsSubAfterSync_FilterRemoved(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test with multiple subscriptions?
1 sub will not be modified
1 sub will be modified
both should work as expected before and after modification

if this test already exists, please ignore, i could not find it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mfaizanse mfaizanse marked this pull request as draft January 26, 2022 12:52
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2022
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2022
@mfaizanse mfaizanse marked this pull request as ready for review January 26, 2022 16:11
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2022
@mfaizanse @k15r
Apply suggestions from code review
5e6d58a 
Co-authored-by: Korbinian Stoemmer <github@k15r.dev>
@mfaizanse
Copy link
Member Author

/retest

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 28, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 28, 2022
@mfaizanse
Copy link
Member Author

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Jan 28, 2022 •
edited

@mfaizanse: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-skr-eventing d5a8084 link false /test pre-main-kyma-skr-eventing

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfaizanse mfaizanse removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2022
@kyma-bot kyma-bot merged commit b1e7bcc into kyma-project:main Jan 28, 2022
@mfaizanse mfaizanse deleted the nats_handler_improve branch January 28, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

@friedrichwilken friedrichwilken Awaiting requested review from friedrichwilken

@lilitgh lilitgh Awaiting requested review from lilitgh

@marcobebway marcobebway Awaiting requested review from marcobebway

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@pxsalehi pxsalehi Awaiting requested review from pxsalehi

@vpaskar vpaskar Awaiting requested review from vpaskar

Assignees

@k15r k15r

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the NATs reconciler to not delete all NATS subscriptions if the subscription filters are modified
3 participants
@mfaizanse @kyma-bot @k15r