Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy the X-Forwarded-* headers #13171

Merged
merged 13 commits into from Feb 11, 2022
Merged

Proxy the X-Forwarded-* headers #13171

merged 13 commits into from Feb 11, 2022

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Jan 25, 2022

Description
We now, proxy the X-Forwader headers instead of deleting them from the request.

Changes proposed in this pull request:

  • the X-Forwarded headers are now handled and forwarded through the proxy.

Related issue(s)
#12190

@mvshao mvshao added the area/application-connector Issues or PRs related to application connectivity label Jan 25, 2022
@mvshao mvshao self-assigned this Jan 25, 2022
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2022
@mvshao mvshao linked an issue Jan 25, 2022 that may be closed by this pull request
Proxy the X-Forwarded-* headers in Application Gateway and Central Application Gateway #12190
Closed
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2022
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2022
@mvshao
Copy link
Contributor Author

mvshao commented Feb 7, 2022

/test pre-main-kyma-gardener-azure-alpha-prod

@netlify
Copy link

netlify bot commented Feb 7, 2022 •
edited

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: fdd4c8f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/620380b59f9eac000816c541

😎 Browse the preview: https://deploy-preview-13171--kyma-project-docs-preview.netlify.app

@mvshao
Copy link
Contributor Author

mvshao commented Feb 7, 2022

/test pre-main-kyma-integration-k3d-compass-dev

@mvshao
Copy link
Contributor Author

mvshao commented Feb 7, 2022

/test pre-main-kyma-gardener-azure-alpha-eval

@mvshao
Copy link
Contributor Author

mvshao commented Feb 8, 2022

/test pre-main-kyma-gardener-azure-alpha-eval

koala7659
koala7659 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 11, 2022
@mvshao
Copy link
Contributor Author

mvshao commented Feb 11, 2022

/test pre-main-kyma-integration-k3d

@kyma-bot kyma-bot merged commit 6d43044 into kyma-project:main Feb 11, 2022
@kyma-bot
Copy link
Contributor

@mvshao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kyma-tests-serverless-bench 790812b link true /test pre-kyma-tests-serverless-bench
pre-main-kyma-gardener-gcp-eventing fdd4c8f link unknown /test pre-main-kyma-gardener-gcp-eventing

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mvshao mvshao deleted the x-forwarded branch February 16, 2022 13:00
@majakurcius majakurcius mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

@akgalwas akgalwas Awaiting requested review from akgalwas

@franpog859 franpog859 Awaiting requested review from franpog859

@janmedrek janmedrek Awaiting requested review from janmedrek

@Maladie Maladie Awaiting requested review from Maladie

@ralikio ralikio Awaiting requested review from ralikio

Assignees

@koala7659 koala7659

@mvshao mvshao

Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy the X-Forwarded-* headers in Application Gateway and Central Application Gateway
3 participants
@mvshao @kyma-bot @koala7659