Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-functional improvements in event-publisher-proxy (documentation, testing) #13247

Merged
merged 38 commits into from Mar 11, 2022
Merged

Non-functional improvements in event-publisher-proxy (documentation, testing) #13247

merged 38 commits into from Mar 11, 2022

Conversation

nachtmaar
Copy link
Contributor

@nachtmaar nachtmaar commented Feb 2, 2022 •
edited

Description

The following changes have been performed while reviewing some code in the event-publisher-proxy.

This PR adds several non-functional improvements such as:

  • Some documentation
  • Using functional options pattern for pkgnats.Connection
  • Fix goroutine loop bug in some parallel tests (see here for more explanation)

About the failing optional eventing tests:

Related issue(s)

marcobebway and others added 20 commits January 20, 2022 22:23
@nachtmaar nachtmaar added the area/eventing Issues or PRs related to eventing label Feb 2, 2022
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 2, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2022
@nachtmaar
Copy link
Contributor Author

nachtmaar commented Feb 2, 2022 •
edited

Blocked until #13120 is merged because it is based on it.

@nachtmaar nachtmaar mentioned this pull request Feb 2, 2022
Closed
@netlify
Copy link

netlify bot commented Feb 2, 2022 •
edited

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: 1513efb

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/620131478db7530009f65d43

😎 Browse the preview: https://deploy-preview-13247--kyma-project-docs-preview.netlify.app

@nachtmaar nachtmaar mentioned this pull request Feb 11, 2022
Closed
4 tasks
@nachtmaar nachtmaar requested a review from raypinto as a code owner March 8, 2022 11:08
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2022
@nachtmaar nachtmaar requested a review from k15r March 8, 2022 17:58
@nachtmaar
Copy link
Contributor Author

/retest

@nachtmaar
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-compass-dev

@nachtmaar
Copy link
Contributor Author

/remove-hold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2022
@friedrichwilken friedrichwilken self-assigned this Mar 11, 2022
@friedrichwilken
Copy link
Contributor

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 11, 2022
@friedrichwilken
Copy link
Contributor

/retest

@kyma-bot kyma-bot merged commit c37665e into kyma-project:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

@lilitgh lilitgh Awaiting requested review from lilitgh

@marcobebway marcobebway Awaiting requested review from marcobebway

@mfaizanse mfaizanse Awaiting requested review from mfaizanse

@pxsalehi pxsalehi Awaiting requested review from pxsalehi

@vpaskar vpaskar Awaiting requested review from vpaskar

@raypinto raypinto Awaiting requested review from raypinto

@k15r k15r Awaiting requested review from k15r

Assignees

@nachtmaar nachtmaar

@friedrichwilken friedrichwilken

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nachtmaar @kyma-bot @marcobebway @friedrichwilken @k15r