Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude cert expiration alert in monitoring tests #13257

Merged
merged 2 commits into from Feb 2, 2022

Conversation

skhalash
Copy link
Contributor

@skhalash skhalash commented Feb 2, 2022

Description

Changes proposed in this pull request:

  • Fix a bug resulting in only non-critical alert taken into account (should be vice versa)
  • Ignore K8sCertificateExpirationNotice alert in tests

Related issue(s)
Fixes #13253

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 2, 2022

@skhalash: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-gcp-eventing-upgrade 76bb12c link false /test pre-main-kyma-gardener-gcp-eventing-upgrade
pre-main-kyma-gardener-gcp-eventing 76bb12c link false /test pre-main-kyma-gardener-gcp-eventing

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 2, 2022
@kyma-bot kyma-bot merged commit 0f5c895 into kyma-project:main Feb 2, 2022
@skhalash skhalash deleted the ignore-api-server-cert-expiry branch February 2, 2022 21:35
@a-thaler a-thaler added the area/monitoring Issues or PRs related to the monitoring module (deprecated) label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration jobs fails on prometheus alerts about Kubernetes API certificate expiration
4 participants