Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup feature flag and scaffolding for a JetStream backend #13259

Merged
merged 2 commits into from Feb 10, 2022
Merged

Setup feature flag and scaffolding for a JetStream backend #13259

merged 2 commits into from Feb 10, 2022

Conversation

pxsalehi
Copy link
Contributor

@pxsalehi pxsalehi commented Feb 2, 2022

Description

Changes proposed in this pull request:

  • Feature flag and scaffolding for a JetStream backend and reconciler

Related issue(s)

Closes #13251

@pxsalehi pxsalehi added the area/eventing Issues or PRs related to eventing label Feb 2, 2022
@pxsalehi pxsalehi self-assigned this Feb 2, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 2, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2022
@pxsalehi pxsalehi marked this pull request as ready for review February 3, 2022 10:32
@pxsalehi pxsalehi requested a review from a user February 3, 2022 10:32
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2022
@pxsalehi pxsalehi added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2022
@pxsalehi
Copy link
Contributor Author

pxsalehi commented Feb 3, 2022

/retest

@pxsalehi pxsalehi force-pushed the ps-jetstream-scaffolding branch 4 times, most recently from cb2988f to f147d64 Compare February 7, 2022 14:50
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2022
@pxsalehi pxsalehi force-pushed the ps-jetstream-scaffolding branch 2 times, most recently from e005b18 to 3b83958 Compare February 8, 2022 12:45
@pxsalehi
Copy link
Contributor Author

pxsalehi commented Feb 8, 2022

/test pre-main-kyma-gardener-gcp-eventing

@pxsalehi
Copy link
Contributor Author

pxsalehi commented Feb 8, 2022

/test pre-main-kyma-gardener-azure-alpha-eval

@kyma-project kyma-project deleted a comment from kyma-bot Feb 8, 2022
@pxsalehi pxsalehi mentioned this pull request Feb 8, 2022
Closed
@pxsalehi
Copy link
Contributor Author

pxsalehi commented Feb 8, 2022

/test pre-main-kyma-gardener-gcp-eventing
/test pre-main-kyma-gardener-azure-alpha-prod

@kyma-project kyma-project deleted a comment from kyma-bot Feb 9, 2022
@pxsalehi pxsalehi removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@pxsalehi
Copy link
Contributor Author

pxsalehi commented Feb 9, 2022

/test pre-main-kyma-gardener-gcp-eventing
/test pre-main-kyma-gardener-gcp-eventing-upgrade
/test pre-main-kyma-gardener-azure-alpha-eval

@mfaizanse mfaizanse self-assigned this Feb 10, 2022
@pxsalehi
Copy link
Contributor Author

/test pre-main-kyma-gardener-gcp-eventing
/test pre-main-kyma-gardener-azure-alpha-prod

mfaizanse
mfaizanse reviewed Feb 10, 2022
View reviewed changes
components/eventing-controller/controllers/subscription/jetstream/reconciler.go
r.namedLogger().Errorw("setup watch for subscriptions failed", "error", err)
return err
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) should we also set a watch for nats pods. As in NATS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. IMO adding other watchers should happen depending on the logic, which is empty for now.

components/eventing-controller/pkg/subscriptionmanager/jetstream/jetstream.go
sm.mgr.GetEventRecorderFor("eventing-controller-jetstream"),
sm.envCfg,
)
// TODO(PS): this could be refactored (also in other backends), so that the backend is created here and passed to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) is this TODO(PS) relevant for the team? or was it for you only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also for the team. Just an old habit! Is it ok to leave it like that? Most likely, I'll work on it as part of the missing unit test tickets.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 10, 2022
@kyma-bot kyma-bot merged commit d4ca7fe into kyma-project:main Feb 10, 2022
@pxsalehi pxsalehi deleted the ps-jetstream-scaffolding branch February 10, 2022 13:21
@kyma-bot
Copy link
Contributor

@pxsalehi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-gcp-eventing 69898c4 link unknown /test pre-main-kyma-gardener-gcp-eventing
pre-main-kyma-gardener-gcp-eventing-upgrade 69898c4 link unknown /test pre-main-kyma-gardener-gcp-eventing-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

@friedrichwilken friedrichwilken Awaiting requested review from friedrichwilken

@k15r k15r Awaiting requested review from k15r

@lilitgh lilitgh Awaiting requested review from lilitgh

@marcobebway marcobebway Awaiting requested review from marcobebway

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@vpaskar vpaskar Awaiting requested review from vpaskar

Assignees

@pxsalehi pxsalehi

@mfaizanse mfaizanse

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup feature flag and scaffolding for a JetStream backend
3 participants
@pxsalehi @kyma-bot @mfaizanse