Refactor tests NATS controller reconciler #13324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichwilken
requested review from
k15r,
lilitgh,
marcobebway,
mfaizanse,
nachtmaar and
pxsalehi
as code owners
kyma-bot
added
the
size/XL
friedrichwilken
changed the title
kyma-bot
added
the
do-not-merge/work-in-progress
|
✔️ 🥰 Documentation preview ready! 🥰 🔨 Explore the source changes: faa5ddd 🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6203e33b123b550007994fd6 😎 Browse the preview: https://deploy-preview-13324--kyma-project-docs-preview.netlify.app |
friedrichwilken
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
friedrichwilken
changed the title
nachtmaar
reviewed
Feb 9, 2022
There was a problem hiding this comment.
Thank you for your work on improving the tests 💪 😃
I left quite a lot of comments, but they are not really related to your changes. That means you don't have to work on (all/any) of them. However I wanted to start a discussion on the tests itself, now that I am reading through most of them.
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Show resolved
Hide resolved
components/eventing-controller/controllers/subscription/nats/reconciler_test.go
Outdated
Show resolved
Hide resolved
|
/lgtm |
nachtmaar
approved these changes
Feb 9, 2022
|
/retest |
friedrichwilken
deleted the
restructure-tests-nats-controller-reconciler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactoring to to the integration tests in controller/ subscription/nats.