Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor eventing mock server #13330

Merged
merged 12 commits into from Feb 10, 2022
Merged

Refactor eventing mock server #13330

merged 12 commits into from Feb 10, 2022

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Feb 9, 2022 •
edited

Description

Changes proposed in this pull request:

  • proper cleanup after tests
  • improve readability of the mock server handler

Related issue(s)

@k15r k15r requested a review from a user February 9, 2022 14:35
@k15r k15r added the area/eventing Issues or PRs related to eventing label Feb 9, 2022
@k15r k15r requested a review from vpaskar as a code owner February 9, 2022 14:35
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2022
@friedrichwilken
Copy link
Contributor

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 10, 2022
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2022
@k15r k15r changed the title close mockserver at the end of test executions Refactor eventing mock server Feb 10, 2022
@k15r k15r mentioned this pull request Feb 10, 2022
Closed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 10, 2022
@kyma-bot kyma-bot merged commit 9b8bda2 into kyma-project:main Feb 10, 2022
@k15r k15r deleted the close-mock branch February 10, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

@lilitgh lilitgh Awaiting requested review from lilitgh

@marcobebway marcobebway Awaiting requested review from marcobebway

@mfaizanse mfaizanse Awaiting requested review from mfaizanse

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@pxsalehi pxsalehi Awaiting requested review from pxsalehi

@vpaskar vpaskar Awaiting requested review from vpaskar

Assignees

@friedrichwilken friedrichwilken

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k15r @friedrichwilken @kyma-bot