Clear subscription status in JetStream reconciler #13394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
requested review from
k15r,
lilitgh,
marcobebway and
nachtmaar
as code owners
pxsalehi
requested review from
mfaizanse,
friedrichwilken and
vpaskar
as code owners
kyma-bot
added
the
size/M
|
/test pre-main-kyma-gardener-gcp-eventing |
pxsalehi
commented
Feb 15, 2022
| @@ -42,19 +42,32 @@ func main() { | |||
| // Set controller core logger. | |||
| ctrl.SetLogger(zapr.NewLogger(ctrLogger.WithContext().Desugar())) | |||
|
|
|||
| // Add schemes. | |||
There was a problem hiding this comment.
Changes in this file are just to add the AddToScheme call for JetStream within the same if.
|
/test pre-main-kyma-integration-k3d |
|
/test pre-main-kyma-gardener-gcp-eventing-upgrade |
mfaizanse
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing #13316, I found out that the "empty" JetStream reconciler (done in #13251) should at lease make sure subscription status is cleared, as otherwise, during an upgrade with feature flag enabled, the subscription would still be reported as ready.
Marking the subscription as not ready makes the tests fail quicker, and it is clear why the test fails (i.e. the subscription is not ready).