Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement validating webhook for telemetry operator #13597

Merged
merged 35 commits into from Mar 23, 2022
Merged

Implement validating webhook for telemetry operator #13597

merged 35 commits into from Mar 23, 2022

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Mar 10, 2022 •
edited

Description

Changes proposed in this pull request:

  • Implement validating webhook
  • Adapted the charts to have validating webhook
  • ...

Related issue(s)

#11831

@rakesh-garimella rakesh-garimella added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 10, 2022
@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited

✅ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: efd9958

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6239bf9f64114e0008716e58

😎 Browse the preview: https://deploy-preview-13597--kyma-project-docs-preview.netlify.app

@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2022
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 14, 2022
@halamix2
Copy link
Member

/test pre-kyma-components-telemetry-operator

@halamix2
Copy link
Member

/test pre-main-kyma-protecode-guard

@rakesh-garimella
Copy link
Contributor Author

/retest

@rakesh-garimella
Copy link
Contributor Author

/retest pre-main-kyma-protecode-guard

@kyma-bot
Copy link
Contributor

@rakesh-garimella: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test kyma-metadata-schema-governance
  • /test pre-kyma-artifacts
  • /test pre-kyma-components-application-broker
  • /test pre-kyma-components-application-connectivity-certs-setup-job
  • /test pre-kyma-components-application-registry
  • /test pre-kyma-components-central-application-connectivity-validator
  • /test pre-kyma-components-central-application-gateway
  • /test pre-kyma-components-compass-runtime-agent
  • /test pre-kyma-components-connection-token-handler
  • /test pre-kyma-components-connector-service
  • /test pre-kyma-components-event-publisher-proxy
  • /test pre-kyma-components-eventing-controller
  • /test pre-kyma-components-function-controller
  • /test pre-kyma-components-function-runtimes
  • /test pre-kyma-components-service-binding-usage-controller
  • /test pre-kyma-components-telemetry-operator
  • /test pre-kyma-components-uaa-activator
  • /test pre-kyma-tests-application-connector-tests
  • /test pre-kyma-tests-application-registry-tests
  • /test pre-kyma-tests-compass-runtime-agent
  • /test pre-kyma-tests-connection-token-handler-tests
  • /test pre-kyma-tests-connector-service-tests
  • /test pre-kyma-tests-function-controller
  • /test pre-kyma-tests-integration-api-gateway
  • /test pre-kyma-tests-rafter
  • /test pre-kyma-tests-serverless-bench
  • /test pre-kyma-tests-service-catalog
  • /test pre-main-kyma-common
  • /test pre-main-kyma-gke-external-registry
  • /test pre-main-kyma-governance
  • /test pre-main-kyma-integration-k3d
  • /test pre-main-kyma-integration-k3d-central-app-connectivity
  • /test pre-main-kyma-integration-k3d-central-app-connectivity-compass
  • /test pre-main-kyma-integration-k3d-telemetry
  • /test pre-main-kyma-protecode-guard
  • /test pre-main-kyma-validate-dockerfiles
  • /test pre-main-serverless-integration-k3s

The following commands are available to trigger optional jobs:

  • /test pre-kyma-components-busola-migrator
  • /test pre-kyma-tools-event-subscriber
  • /test pre-kyma-tools-gitserver
  • /test pre-main-check-users-map
  • /test pre-main-kyma-component-descriptors
  • /test pre-main-kyma-gardener-azure-alpha-eval
  • /test pre-main-kyma-gardener-azure-alpha-prod
  • /test pre-main-kyma-gardener-azure-fast-integration
  • /test pre-main-kyma-gardener-gcp-eventing
  • /test pre-main-kyma-gardener-gcp-eventing-upgrade
  • /test pre-main-kyma-integration-k3d-compass-dev
  • /test pre-main-kyma-skr-eventing
  • /test pre-main-kyma-validate-image-definitions

Use /test all to run the following jobs that were automatically triggered:

  • pre-kyma-artifacts
  • pre-kyma-components-telemetry-operator
  • pre-main-check-users-map
  • pre-main-kyma-component-descriptors
  • pre-main-kyma-gardener-azure-alpha-eval
  • pre-main-kyma-gardener-azure-alpha-prod
  • pre-main-kyma-gardener-gcp-eventing
  • pre-main-kyma-gardener-gcp-eventing-upgrade
  • pre-main-kyma-integration-k3d
  • pre-main-kyma-integration-k3d-central-app-connectivity
  • pre-main-kyma-integration-k3d-central-app-connectivity-compass
  • pre-main-kyma-integration-k3d-compass-dev
  • pre-main-kyma-integration-k3d-telemetry
  • pre-main-kyma-protecode-guard
  • pre-main-kyma-skr-eventing
  • pre-main-kyma-validate-dockerfiles
  • pre-main-kyma-validate-image-definitions

In response to this:

/retest pre-main-kyma-protecode-guard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dennis-ge
Copy link
Contributor

dennis-ge commented Mar 21, 2022 •
edited

The output when applying a faulty LogPipeline CR looks like the following:

$ k apply -f tests/fast-integration/telemetry-test/invalid-log-pipeline.yaml
Error from server (InvalidConfiguration): error when creating "tests/fast-integration/telemetry-test/invalid-log-pipeline.yaml": admission webhook "validation.webhook.telemetry.kyma-project.io" denied the request: The Fluent Bit dry-run could not validate the provided Log Pipeline: Error in line 3: Invalid indentation level

Unfortunately we can only influence the error reason (in the example InvalidConfiguration) and the error message (in the example The Fluent Bit dry-run ...). All other errors are creating on kubectl side.

@NHingerl, @rakesh-garimella and @a-thaler, what do you think?

@dennis-ge
Copy link
Contributor

/test pre-main-kyma-integration-k3d-telemetry

@dennis-ge
Copy link
Contributor

/test pre-main-kyma-integration-k3d-telemetry

skhalash
skhalash previously approved these changes Mar 21, 2022
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 21, 2022
@dennis-ge dennis-ge added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2022
@dennis-ge
Copy link
Contributor

/test pre-main-kyma-integration-k3d

@a-thaler
Copy link
Contributor

The validation happened but failed, so we should phrase more like:
Validation of the supplied configuration by running a FluentBit dry-run failed with following message

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 22, 2022
@dennis-ge
Copy link
Contributor

/test pre-main-kyma-integration-k3d-compass-dev

@kyma-bot kyma-bot added the area/logging Issues or PRs related to the logging module (deprecated) label Mar 22, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 22, 2022
@dennis-ge dennis-ge removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 23, 2022 •
edited

@rakesh-garimella: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-gcp-eventing 2615f02 link false /test pre-main-kyma-gardener-gcp-eventing
pre-main-kyma-skr-eventing 2615f02 link false /test pre-main-kyma-skr-eventing
pre-main-kyma-gardener-azure-alpha-eval 2615f02 link false /test pre-main-kyma-gardener-azure-alpha-eval

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dennis-ge
Copy link
Contributor

/test pre-main-kyma-integration-k3d-central-app-connectivity

@kyma-bot kyma-bot merged commit 3ea8a95 into kyma-project:main Mar 23, 2022
@chrkl chrkl mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

@a-thaler a-thaler Awaiting requested review from a-thaler

@lilitgh lilitgh Awaiting requested review from lilitgh

@clebs clebs Awaiting requested review from clebs

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@chrkl chrkl Awaiting requested review from chrkl

@lindnerby lindnerby Awaiting requested review from lindnerby

@dennis-ge dennis-ge Awaiting requested review from dennis-ge

@pbochynski pbochynski Awaiting requested review from pbochynski

@fourthisle fourthisle Awaiting requested review from fourthisle

@ruanxin ruanxin Awaiting requested review from ruanxin

@tobiscr tobiscr Awaiting requested review from tobiscr

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

Assignees

@skhalash skhalash

Labels
area/logging Issues or PRs related to the logging module (deprecated) lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Telemetry Operator] Validate Fluent Bit Configuration
6 participants
@rakesh-garimella @dennis-ge @halamix2 @kyma-bot @a-thaler @skhalash