Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove kyma 1 related resources #13622

Merged
merged 8 commits into from Mar 17, 2022
Merged

remove kyma 1 related resources #13622

merged 8 commits into from Mar 17, 2022

Conversation

strekm
Copy link
Contributor

@strekm strekm commented Mar 14, 2022 •
edited

Description

Changes proposed in this pull request:

  • removed istio-installer
  • remove installation/certs
  • remove installation/scripts
  • passing CODEOWNERS of installation folder to @tobiscr

Related issue(s)

@strekm strekm added area/installation Issues or PRs related to installation do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 14, 2022
@strekm strekm added this to the 2.1 milestone Mar 14, 2022
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 14, 2022
@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited

✔️ 🥰 Documentation preview ready! 🥰

🔨 Explore the source changes: c9101c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6232efec3276300009406ecc

😎 Browse the preview: https://deploy-preview-13622--kyma-project-docs-preview.netlify.app

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2022
@strekm
Copy link
Contributor Author

strekm commented Mar 14, 2022

/test all

@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2022
@strekm strekm changed the title remove kyma 1 relater resources remove kyma 1 related resources Mar 14, 2022
@halamix2
Copy link
Member

/retest

@strekm
Copy link
Contributor Author

strekm commented Mar 15, 2022

/test pre-main-kyma-integration-k3d-central-app-connectivity-compass

@strekm
Copy link
Contributor Author

strekm commented Mar 16, 2022

/test pre-main-kyma-gardener-azure-alpha-prod

mjakobczyk
mjakobczyk previously approved these changes Mar 17, 2022
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 17, 2022
majakurcius
majakurcius reviewed Mar 17, 2022
View reviewed changes
installation/README.md Outdated Show resolved Hide resolved
@strekm
Update installation/README.md
c9101c4 
Co-authored-by: Maja Kurcius <maja.kurcius@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 17, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 17, 2022
dennis-ge
dennis-ge approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@dennis-ge dennis-ge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wanted to remove some kyma 1 related stuff in #13578. Closed my PR since it is a duplicate of this one :)

@strekm
Copy link
Contributor Author

strekm commented Mar 17, 2022

/retest

@strekm
Copy link
Contributor Author

strekm commented Mar 17, 2022

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 17, 2022 •
edited

@strekm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kyma-components-istio-installer 35b7d95 link true /test pre-kyma-components-istio-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@strekm
Copy link
Contributor Author

strekm commented Mar 17, 2022

/retest

@kyma-bot kyma-bot merged commit 6ab3c3e into kyma-project:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-thaler a-thaler a-thaler approved these changes

@mjakobczyk mjakobczyk mjakobczyk approved these changes

@dennis-ge dennis-ge dennis-ge approved these changes

@majakurcius majakurcius majakurcius approved these changes

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@NHingerl NHingerl Awaiting requested review from NHingerl

@grego952 grego952 Awaiting requested review from grego952

@werdes72 werdes72 Awaiting requested review from werdes72

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@dariusztutaj dariusztutaj Awaiting requested review from dariusztutaj

@pbochynski pbochynski Awaiting requested review from pbochynski

@PK85 PK85 Awaiting requested review from PK85

@m00g3n m00g3n Awaiting requested review from m00g3n

@pPrecel pPrecel Awaiting requested review from pPrecel

Assignees

@a-thaler a-thaler

@mjakobczyk mjakobczyk

@dennis-ge dennis-ge

@majakurcius majakurcius

Labels
area/installation Issues or PRs related to installation lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@strekm @halamix2 @kyma-bot @a-thaler @mjakobczyk @dennis-ge @majakurcius