Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MaxDeliver config to JetStream consumer #13693

Merged
merged 7 commits into from Mar 24, 2022
Merged

Added MaxDeliver config to JetStream consumer #13693

merged 7 commits into from Mar 24, 2022

Conversation

mfaizanse
Copy link
Member

@mfaizanse mfaizanse commented Mar 22, 2022 •
edited

Description

Changes proposed in this pull request:

  • Set MaxDeliver to 100 for JetStream consumer.
  • Set AckWait to 30 seconds for JetStream consumer.
  • Changed the dispatcher to not NAK the msg if it fails to deliver it to the sink, so that it timeouts after AckWait period and then redeliver. It will keep on trying for 100*30 seconds (50 minutes)

Related issue(s)

@mfaizanse mfaizanse requested a review from a user March 22, 2022 13:41
@kyma-bot kyma-bot added area/eventing Issues or PRs related to eventing size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@mfaizanse mfaizanse linked an issue Mar 22, 2022 that may be closed by this pull request
Check if sending a NACK for an event is counted towards redeliver count in JetStream consumer #13625
Closed
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2022
raypinto
raypinto reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@raypinto raypinto left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
(nit) Maybe a test to show that the maxRedeliver works as expected? If you think it's just a jetstream feature and the test doesn't add value, feel free to drop it.

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 24, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 24, 2022
@mfaizanse
Copy link
Member Author

/retest

@raypinto
Copy link
Contributor

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 24, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 24, 2022
@mfaizanse
Copy link
Member Author

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 24, 2022 •
edited

@mfaizanse: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-gcp-eventing-upgrade 4a6af00 link false /test pre-main-kyma-gardener-gcp-eventing-upgrade
pre-main-kyma-gardener-azure-alpha-prod 4a6af00 link false /test pre-main-kyma-gardener-azure-alpha-prod

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@raypinto
Copy link
Contributor

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 24, 2022
@raypinto
Copy link
Contributor

/test pre-main-kyma-integration-k3d-central-app-connectivity

@kyma-bot kyma-bot merged commit 056b433 into kyma-project:main Mar 24, 2022
@mfaizanse mfaizanse deleted the set_max_deliver branch March 24, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raypinto raypinto raypinto approved these changes

@k15r k15r Awaiting requested review from k15r

@lilitgh lilitgh Awaiting requested review from lilitgh

@marcobebway marcobebway Awaiting requested review from marcobebway

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@pxsalehi pxsalehi Awaiting requested review from pxsalehi

@friedrichwilken friedrichwilken Awaiting requested review from friedrichwilken

@vpaskar vpaskar Awaiting requested review from vpaskar

Assignees

@raypinto raypinto

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if sending a NACK for an event is counted towards redeliver count in JetStream consumer
3 participants
@mfaizanse @raypinto @kyma-bot