Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust default refresh time and time picker for istio dashboards back to kyma defaults #13712

Merged
merged 3 commits into from Mar 24, 2022

Conversation

a-thaler
Copy link
Contributor

@a-thaler a-thaler commented Mar 24, 2022

Description

Changes proposed in this pull request:

  • change default refresh time to 10s for istio dashboards
  • change default time picker to 1h for istio dashboards
  • ...

Related issue(s)

#13706
#13664
#13713

@kyma-bot kyma-bot added area/monitoring Issues or PRs related to the monitoring module (deprecated) area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2022
@a-thaler a-thaler added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@a-thaler a-thaler removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@Ressetkk Ressetkk self-requested a review March 24, 2022 14:10
Ressetkk
Ressetkk previously approved these changes Mar 24, 2022
Copy link
Contributor

@Ressetkk Ressetkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow

@kyma-bot
Copy link
Contributor

@Ressetkk: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 24, 2022
@kyma-bot kyma-bot merged commit b67f70e into kyma-project:release-2.1 Mar 24, 2022
@a-thaler a-thaler deleted the istio3 branch March 24, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants