New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust default refresh time and time picker for istio dashboards back to kyma defaults #13712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-thaler
requested review from
lilitgh,
rakesh-garimella,
skhalash,
chrkl,
lindnerby and
dennis-ge
as code owners
March 24, 2022 10:12
kyma-bot
added
area/monitoring
Issues or PRs related to the monitoring module (deprecated)
area/security
Issues or PRs related to security
area/service-mesh
Issues or PRs related to service-mesh
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Mar 24, 2022
a-thaler
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 24, 2022
chrkl
reviewed
Mar 24, 2022
a-thaler
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 24, 2022
chrkl
approved these changes
Mar 24, 2022
Ressetkk
approved these changes
Mar 24, 2022
Ressetkk
previously approved these changes
Mar 24, 2022
Ressetkk
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/monitoring
Issues or PRs related to the monitoring module (deprecated)
area/security
Issues or PRs related to security
area/service-mesh
Issues or PRs related to service-mesh
lgtm
Looks good to me!
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#13706
#13664
#13713