Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup custom kyma alerts #13758

Merged
merged 4 commits into from Mar 29, 2022
Merged

Cleanup custom kyma alerts #13758

merged 4 commits into from Mar 29, 2022

Conversation

Pranav-SA
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove redundant custom kyma alerts.
  • Update ignore alerts list.
  • Remove apiserver_request_latencies_bucket references.

Related issue(s)
#13290

@kyma-bot kyma-bot added area/charts Issues or PRs related to changes in charts area/monitoring Issues or PRs related to the monitoring module (deprecated) area/tests Issues or PRs related to tests size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2022
@a-thaler
Copy link
Contributor

What is with the "Kyma / Kubernetes / Pods" Dashboard? I think that also should be cleaned up?

@kyma-bot
Copy link
Contributor

@Pranav-SA: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d-compass-dev 3caf186 link false /test pre-main-kyma-integration-k3d-compass-dev
pre-main-kyma-skr-eventing 3caf186 link false /test pre-main-kyma-skr-eventing
pre-main-kyma-gardener-azure-alpha-prod 3caf186 link false /test pre-main-kyma-gardener-azure-alpha-prod
pre-main-kyma-gardener-azure-alpha-eval 3caf186 link false /test pre-main-kyma-gardener-azure-alpha-eval

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 29, 2022
@kyma-bot kyma-bot merged commit b4b0d56 into kyma-project:main Mar 29, 2022
@Pranav-SA Pranav-SA deleted the Cleanup-Alerts branch March 29, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-thaler a-thaler a-thaler left review comments

@skhalash skhalash skhalash approved these changes

@pbochynski pbochynski Awaiting requested review from pbochynski

@rakesh-garimella rakesh-garimella Awaiting requested review from rakesh-garimella

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@lindnerby lindnerby Awaiting requested review from lindnerby

@fourthisle fourthisle Awaiting requested review from fourthisle

@ruanxin ruanxin Awaiting requested review from ruanxin

@tobiscr tobiscr Awaiting requested review from tobiscr

@clebs clebs Awaiting requested review from clebs

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@dennis-ge dennis-ge Awaiting requested review from dennis-ge

@lilitgh lilitgh Awaiting requested review from lilitgh

@chrkl chrkl Awaiting requested review from chrkl

Assignees

@skhalash skhalash

Labels
area/charts Issues or PRs related to changes in charts area/monitoring Issues or PRs related to the monitoring module (deprecated) area/tests Issues or PRs related to tests lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pranav-SA @a-thaler @kyma-bot @skhalash