Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for event publishing to NATS in jetstream mode #13763

Merged
merged 2 commits into from Apr 5, 2022
Merged

Add support for event publishing to NATS in jetstream mode #13763

merged 2 commits into from Apr 5, 2022

Conversation

vpaskar
Copy link
Contributor

@vpaskar vpaskar commented Mar 28, 2022 •
edited

Description

Changes proposed in this pull request:

  • use jetstream client to publish the events
  • add Jestream sender to NATS
  • update the tests and add new ones

Related issue(s)
#13224

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/eventing Issues or PRs related to eventing size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2022
@netlify
Copy link

netlify bot commented Mar 28, 2022 •
edited

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit 7790eda
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/624b06af69a9ef0008d2f72f
😎 Deploy Preview https://deploy-preview-13763--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2022
@vpaskar vpaskar force-pushed the epp-nats-js branch 2 times, most recently from 102689c to 265a1c0 Compare March 29, 2022 14:06
@kyma-bot kyma-bot added the area/charts Issues or PRs related to changes in charts label Mar 29, 2022
@vpaskar vpaskar linked an issue Mar 30, 2022 that may be closed by this pull request
Implement sending to Nats Jetstream using EPP #13224
Closed
4 tasks
@vpaskar vpaskar marked this pull request as ready for review March 30, 2022 13:25
@vpaskar vpaskar requested a review from a user March 30, 2022 13:25
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2022
@vpaskar vpaskar added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2022
@nachtmaar
Copy link
Contributor

/retest

@nachtmaar
Copy link
Contributor

/assign

nachtmaar
nachtmaar reviewed Mar 31, 2022
View reviewed changes
components/event-publisher-proxy/cmd/event-publisher-proxy/main.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/cmd/event-publisher-proxy/main.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/handler/nats/mock/mock.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/handler/nats/mock/mock.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/sender/jetstream.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/sender/jetstream_test.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/sender/jetstream_test.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/handler/nats/health_test.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/sender/jetstream.go Outdated Show resolved Hide resolved
components/event-publisher-proxy/pkg/handler/nats/handler_integration_test.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2022
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 5, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 5, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachtmaar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 5, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 5, 2022 •
edited

@VladislavPaskar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-skr-eventing 58455c5 link false /test pre-main-kyma-skr-eventing

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nachtmaar
Copy link
Contributor

/lgtm

@kyma-bot kyma-bot added lgtm Looks good to me! and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 5, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 5, 2022

@VladislavPaskar: The label(s) /label do-not-merge/work-in-progress cannot be applied. These labels are supported: tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, Epic

In response to this:

/label do-not-merge/work-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 5, 2022
@vpaskar vpaskar changed the title Add support for event publishing to NATS in jetstream mode [WIP] Add support for event publishing to NATS in jetstream mode Apr 5, 2022
@vpaskar vpaskar changed the title [WIP] Add support for event publishing to NATS in jetstream mode Add support for event publishing to NATS in jetstream mode Apr 5, 2022
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2022
@kyma-bot kyma-bot merged commit 43bea76 into kyma-project:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachtmaar nachtmaar nachtmaar approved these changes

@k15r k15r Awaiting requested review from k15r

@lilitgh lilitgh Awaiting requested review from lilitgh

@marcobebway marcobebway Awaiting requested review from marcobebway

@pxsalehi pxsalehi Awaiting requested review from pxsalehi

@mfaizanse mfaizanse Awaiting requested review from mfaizanse

@friedrichwilken friedrichwilken Awaiting requested review from friedrichwilken

@raypinto raypinto Awaiting requested review from raypinto

Assignees

@nachtmaar nachtmaar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/charts Issues or PRs related to changes in charts area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement sending to Nats Jetstream using EPP
3 participants
@vpaskar @kyma-bot @nachtmaar