Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Application connector port names in services to comply with Isti… #13810

Merged
merged 1 commit into from Apr 4, 2022
Merged

Fix Application connector port names in services to comply with Isti… #13810

merged 1 commit into from Apr 4, 2022

Conversation

cnvergence
Copy link
Contributor

Description

We should follow official Istio documentation about port naming convention.

Istioctl analyze output:

Info [IST0118] (Service kyma-integration/application-broker) Port name status-port (port: 15020, targetPort: 15020) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kyma-integration/application-operator-service) Port name  (port: 443, targetPort: 443) doesn't follow the naming convention of Istio port.

Related issue(s)

See:

@kyma-bot kyma-bot added area/application-connector Issues or PRs related to application connectivity area/charts Issues or PRs related to changes in charts size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2022
@cnvergence cnvergence added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2022
@cnvergence
Copy link
Contributor Author

/retest

2 similar comments
@cnvergence
Copy link
Contributor Author

/retest

@cnvergence
Copy link
Contributor Author

/retest

@cnvergence
Copy link
Contributor Author

/test pre-main-kyma-gardener-azure-alpha-prod

@cnvergence
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2022
@cnvergence
Copy link
Contributor Author

/test pre-main-kyma-gardener-azure-alpha-prod

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 4, 2022

@cnvergence: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-azure-alpha-prod accae53 link false /test pre-main-kyma-gardener-azure-alpha-prod

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 4, 2022
@cnvergence
Copy link
Contributor Author

/assign @franpog859

@Ressetkk
Copy link
Contributor

Ressetkk commented Apr 4, 2022

/cc @piotrmiskiewicz

wozniakjan
wozniakjan approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@wozniakjan wozniakjan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wozniakjan
Copy link
Contributor

/approve

1 similar comment
@koala7659
Copy link
Contributor

/approve

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koala7659, wozniakjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@kyma-bot kyma-bot merged commit 4fa7a04 into kyma-project:main Apr 4, 2022
@cnvergence cnvergence deleted the app-operator-port-names branch April 4, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@PK85 PK85 Awaiting requested review from PK85

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz

@szwedm szwedm Awaiting requested review from szwedm

@hanngos hanngos Awaiting requested review from hanngos

@tillknuesting tillknuesting Awaiting requested review from tillknuesting

@ralikio ralikio Awaiting requested review from ralikio

@akgalwas akgalwas Awaiting requested review from akgalwas

@janmedrek janmedrek Awaiting requested review from janmedrek

@franpog859 franpog859 Awaiting requested review from franpog859

@Maladie Maladie Awaiting requested review from Maladie

@koala7659 koala7659 Awaiting requested review from koala7659

Assignees

@wozniakjan wozniakjan

@franpog859 franpog859

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/application-connector Issues or PRs related to application connectivity area/charts Issues or PRs related to changes in charts lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cnvergence @kyma-bot @Ressetkk @wozniakjan @koala7659 @franpog859