Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate key from api-gateway deployment yaml #13826

Merged
merged 1 commit into from Apr 4, 2022

Conversation

lindnerby
Copy link
Member

Description

Key ports is defined two times, although kubernetes is kindly ignoring this and just takes one of the defined ports, but kyma deploy dry-runs when rendering manifests notices this and yaml libraries when parsing invalid yaml will fail.

Related issue(s)

@kyma-bot kyma-bot added area/api-gateway Issues or PRs related to api-gateway area/charts Issues or PRs related to changes in charts area/service-mesh Issues or PRs related to service-mesh size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2022
@veichtj
Copy link
Contributor

veichtj commented Apr 4, 2022

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 4, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: veichtj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 4, 2022

@lindnerby: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-azure-alpha-prod 44b831c link false /test pre-main-kyma-gardener-azure-alpha-prod

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lindnerby
Copy link
Member Author

/retest-required

@kyma-bot kyma-bot merged commit b15938c into kyma-project:main Apr 4, 2022
@lindnerby lindnerby deleted the fix-api-gateway-depl-yaml branch April 4, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api-gateway Issues or PRs related to api-gateway area/charts Issues or PRs related to changes in charts area/service-mesh Issues or PRs related to service-mesh lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants