Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prometheusPortForward leftovers #13871

Merged
merged 1 commit into from Apr 7, 2022
Merged

Remove prometheusPortForward leftovers #13871

merged 1 commit into from Apr 7, 2022

Conversation

skhalash
Copy link
Contributor

@skhalash skhalash commented Apr 7, 2022 •
edited

Description

Changes proposed in this pull request:

Related issue(s)
#13375

@kyma-bot kyma-bot added area/eventing Issues or PRs related to eventing area/tests Issues or PRs related to tests labels Apr 7, 2022
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2022
@skhalash
Copy link
Contributor Author

skhalash commented Apr 7, 2022

/retest

1 similar comment
@skhalash
Copy link
Contributor Author

skhalash commented Apr 7, 2022

/retest

@skhalash
Copy link
Contributor Author

skhalash commented Apr 7, 2022

/test pre-main-kyma-integration-k3d-central-app-connectivity

@skhalash
Copy link
Contributor Author

skhalash commented Apr 7, 2022

/retest

@mfaizanse mfaizanse mentioned this pull request Apr 7, 2022
Closed
@marcobebway
Copy link
Contributor

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 7, 2022
@marcobebway
Copy link
Contributor

/approve

@marcobebway
Copy link
Contributor

/lgtm

wozniakjan
wozniakjan approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcobebway, wozniakjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
@kyma-bot kyma-bot merged commit a7b029e into kyma-project:main Apr 7, 2022
@skhalash skhalash deleted the prometheus-port-forward-leftovers branch April 7, 2022 12:41
koala7659 pushed a commit to koala7659/kyma that referenced this pull request May 5, 2022
@skhalash @koala7659
Remove prometheusPortForward leftovers (kyma-project#13871)
8906179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@marcobebway marcobebway marcobebway approved these changes

@hanngos hanngos Awaiting requested review from hanngos

Assignees

@wozniakjan wozniakjan

@marcobebway marcobebway

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/eventing Issues or PRs related to eventing area/tests Issues or PRs related to tests lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skhalash @marcobebway @kyma-bot @wozniakjan